gugod / libravatar

A ruby interface for libravatar avatar service.
https://www.libravatar.org/
MIT License
5 stars 3 forks source link

SRV discovery causes fatal error on non-standard port discovery #7

Closed sunchaserinfo closed 8 years ago

sunchaserinfo commented 11 years ago

Case:

Error:

no implicit conversion of Fixnum into String

libravatar (1.2.0) lib/libravatar.rb:87:in '+' libravatar (1.2.0) lib/libravatar.rb:87:in 'get_base_url' libravatar (1.2.0) lib/libravatar.rb:107:in 'to_s' app/views/libravatar/test.html.erb:3:in '_app_views_libravatar_test_html_erb___3623993676016155218_69829426226360'

Fix:

libravatar.rb:87

change port_fragment = port != profile[:port] ? ':' + port : '' to port_fragment = port != profile[:port] ? ':' + port.to_s : ''

sunchaserinfo commented 10 years ago

is this gem abandoned?

arokettu commented 8 years ago

I integrated your patch to my fork - https://github.com/sandfoxme/libravatar

sunchaserinfo commented 8 years ago

@sandfoxme great