View.ColorScheme setter should likely call setNeedsDisplay ()

gui-cs / Terminal.Gui

Cross Platform Terminal UI toolkit for .NET

MIT License

9.66k stars 689 forks source link

View.ColorScheme setter should likely call setNeedsDisplay () #1078

Closed migueldeicaza closed 3 years ago

migueldeicaza commented 3 years ago

So it triggers a re-display.

BDisp commented 3 years ago

I agree.

BDisp commented 3 years ago

Although I had agreed, now I have some doubts. On cases where the user are setting some configurations and only want apply on exit or on a reinitialization, the changes is immediately apply, which the user maybe don't want. In this case is better the user call the SetNeededDisplaylater.

migueldeicaza commented 3 years ago

Generally, I don't think that gui.cs is modeled after a reinitialization - generally, the properties have an immediate effect.