LayoutSubviews should be restricted to the `ContentSize` and not `Viewport.Size`

[BDisp]

@tig I think this wasn't happening before.

[tig]

@tig I think this wasn't happening before.

Uncheck ClearContentOnly and ClipContentOnly I have them on by default to illustrate how they work.

[tig]

See the API docs for these here:

https://gui-cs.github.io/Terminal.GuiV2Docs/api/Terminal.Gui.ViewportSettings.html

[BDisp]

What I want to get across with this post is that recalculating subview positions should only change when the ContentSize changes and not when the viewport size changes. Of course I'm referring to non-absolute Pos/Dim.

[dodexahedron]

That doesn't sound right to me. 🤔

If something is centered or otherwise relative to anything but top left, its position will (or should, anyway) change if the viewport changes, no?

[tig]

What I want to get across with this post is that recalculating subview positions should only change when the ContentSize changes and not when the viewport size changes. Of course I'm referring to non-absolute Pos/Dim.

Right you are.

Not sure how that happened or how I missed a unit test for it. I'll fix asap.

[tig]

That doesn't sound right to me. 🤔

If something is centered or otherwise relative to anything but top left, its position will (or should, anyway) change if the viewport changes, no?

Layout is tied to the "Content Area" which is defined by View.ContentSize. A subview with X = Pos.Center() will be at the center of ContentSize.Width.

By default Viewport.Size is the same as ContentSize. In that case, you are right.

However, the whole point of ContentSize is to enable a virtual content area that is independent from the Viewport. In this scenario, we set ContentSize to 60x40 and thus X = Pos.Center() should NOT be centered in Viewport.

[tig]

What I want to get across with this post is that recalculating subview positions should only change when the ContentSize changes and not when the viewport size changes. Of course I'm referring to non-absolute Pos/Dim.

Right you are.

Not sure how that happened or how I missed a unit test for it. I'll fix asap.

I see what I did. In cleaning up some old Dim.Auto code I had in LayoutSubviews I goofed. This is correct:

I'll fix this asap and add more unit tests!

[dodexahedron]

By default Viewport.Size is the same as ContentSize. In that case, you are right.

Yeah, that was the thought process involved there.

The rest makes sense and sounds good to me, as well. 👍

[BDisp]

I'll fix this asap and add more unit tests!

How about enable FineCodeCoverage again? This way we could have statistics on the APIs whose unit tests remain to be created. Of course, we have to exclude unit testing of operating system-specific drivers for now.