gui-cs / Terminal.Gui

Cross Platform Terminal UI toolkit for .NET
MIT License
9.7k stars 690 forks source link

Finalize v2 Default Visual Style #3493

Open tig opened 5 months ago

tig commented 5 months ago

I'd like apps built with V2 to be visually distinct from v1. Right now, there are some subtle differences. I'd like this Issue to drive discussion on what we want the default look & feel to be.

Here's my current vision:

Colors

So-far:

What's needed:

I really hope we can figure out these issues for V2 beta. They will be "Right" and will drive obvious visual distinction:

We will then need to pick great default colorschemes.

View Adornments

So-far:

What's needed:

Styling

What's needed

Views

So-Far

What are other's thoughts?

dodexahedron commented 5 months ago

Good goals.

I'll more specifically sit down to think about the specifics of this issue and chime in with suggestions after some of my pipeline clears.

BDisp commented 1 month ago

The reason why I prefer only the button shadow is hidden when pressed is because the original location of the button pressed is the same as the button released.

tig commented 1 month ago

The reason why I prefer only the button shadow is hidden when pressed is because the original location of the button pressed is the same as the button released.

I think we have these choices when there's a shadow on a button:

  1. Move nothing. Don't hide shadow.
  2. Hide the shadow., but don't move the button
  3. Hide the shadow, move the button one cell to right.
  4. Hide the shadow, move the button one cell to right and one cell down.

The current design (as of #3750) is 3 above:

iViR1ra 1

If I understand you correctly you are saying you prefer 2.

In

it was discussed and suggested that another system did 3 instead of 4, which was how I originally had it.

I felt 3 was best because with 4 the button moved way too much. 3 has nice motion but is sublte.

What do others think?

tig commented 1 month ago

This is 1. Move nothing. Don't hide shadow:

9Wc1VCu 1

This is 2. Hide the shadow., but don't move the button:

mb9qwse 1

This is 3. Hide the shadow, move the button one cell to right.:

iViR1ra 1

This is 4. Hide the shadow, move the button one cell to right and one cell down.:

y2Z7K6j 1

tig commented 1 month ago

Everyone note that in #3751 I've

FWIW, the other two themes are specified by UI Catalog as a way of testing that app-level themes work.

dLNOLyc 1

BDisp commented 1 month ago

I vote for 2. In the reality what happens is when the button isn't pressed it's away from the surface but in the same position with a light over him at some angle. When is pressed it's stuck to the surface eliminating the shadow. If the option 2 isn't accepted by the majority then the option 3 is a good choice.