search

gui-cs / Terminal.Gui

Cross Platform Terminal UI toolkit for .NET
MIT License
9.63k stars 687 forks source link

Force 16 colors doesn't provide visual effect to MenuBar. #3759

Open BDisp opened 2 weeks ago

BDisp commented 2 weeks ago

@tig I don't know how you want to fix this and I'll leaving this for you.

WindowsTerminal_VNLx0Akt4a

tig commented 2 weeks ago

Yeah. Good call out.

I'm not sure what the right approach is to deal with this.

BDisp commented 2 weeks ago

Yeah. Good call out.

I'm not sure what the right approach is to deal with this.

I think the best approach is having two configuration, one for true color and other for 16 colors. If driver doesn't support true color then fallbacks to the 16 colors, which can't have a variant of the same color.

tig commented 2 weeks ago

Yeah. Good call out. I'm not sure what the right approach is to deal with this.

I think the best approach is having two configuration, one for true color and other for 16 colors. If driver doesn't support true color then fallbacks to the 16 colors, which can't have a variant of the same color.

That might work, but then we'd have to figure out how to auto select it.

I think this can be fixed by making CalculateColorDistance smarter.