search

gui-cs / TerminalGuiDesigner

Forms Designer for Terminal.Gui (aka gui.cs)
MIT License
426 stars 28 forks source link

Fixes #226. Toplevel or Window should allow set IsMdiContainer property. #229

Closed BDisp closed 4 weeks ago

tznind commented 1 year ago

What do you think about using SuppressedProperty for this now? might reduce scope for issues?

BDisp commented 1 year ago

What do you think about using SuppressedProperty for this now? might reduce scope for issues?

It seems the PR's are being merge again. I have two v1 PR to be accepted and I think it's will published a new version and now the develop branch seems to publish a preview version to nuget packages. But do what you think that is better for you, don't worry.

BDisp commented 1 year ago

I see now your concern. But I need to clarify how MdiContainer works. An app only can have a MdiContainer toplevel. If you run another MdiContainer toplevel will throw an exception. Imagine TerminalGuiDesigner is a MdiContainer and the user create a MdiContainer app. TerminalGuiDesigner will throw an exception when the user open a file that is a MdiContainer. But it seems that the SuppressedProperty only set a subview property and not the root itself, right? If is the case then you need to suppress the IsMdiContainer to false before load the root. I hope I didn't said any stupidity.