gui-cs / TerminalGuiDesigner

Forms Designer for Terminal.Gui (aka gui.cs)
MIT License
423 stars 28 forks source link

Conversion of unit tests to NUnit's Constraint model #258

Open dodexahedron opened 9 months ago

dodexahedron commented 9 months ago

The old classic assertion style has been deprecated for quite a while, now, and NUnit 4 takes that a step further by actually moving them off to a separate project and namespace.

I've been working on converting the tests to the new model, in my repo.

I branched from your latest v2_latest_changes_pre_220 branch commit and work is going into convert-tests-to-constraint-model on my repo. I'll open up a PR at some point for easier tracking of what's going on, as work is done.

But I did have a couple of questions about TerminalGuiDesigner for you, @tznind , that came up as I have been going through the tests.\ I'd like to chat with you at some point, when you have some time, both to get some clarity on a couple of questions as well as to bounce some ideas off of you regarding something it looks like I might be able to help out with - I just need to be sure I understand it properly before I go any further down that rabbit hole (which isn't that deep, but I want to be sure the intent and result is the same).

I've created a project and issues over at my fork to track the work.

Project: https://github.com/users/dodexahedron/projects/4

Main conversion issue: https://github.com/dodexahedron/TerminalGuiDesigner/issues/1

Branch for conversion work: https://github.com/dodexahedron/TerminalGuiDesigner/tree/convert-tests-to-constraint-model

I'm opening this issue up over here mostly as a placeholder to indicate and link to work being done.\ I'll file other issues related to it over there, since it's likely to get a bit noisy.

If you have any thoughts, requests, ideas, commentary, concerns, or whatever, just hit me up over there. :)

dodexahedron commented 9 months ago

Opened #259 as draft PR to track here as work goes on over there.

tznind commented 9 months ago

Awesome stuff! I'm excited by new ideas so can't wait to hear more about your thoughts.

I'm away this weekend so only have mobile access but will be back tomorrow evening and can go over any aspects of the design of the code you have questions about 😃

On Sat, 2 Dec 2023, 22:35 dodexahedron, @.***> wrote:

Opened #259 https://github.com/gui-cs/TerminalGuiDesigner/pull/259 as draft PR to track here as work goes on over there.

— Reply to this email directly, view it on GitHub https://github.com/gui-cs/TerminalGuiDesigner/issues/258#issuecomment-1837270044, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHO3C5DHM4K56BISEMZZHXTYHOUJ3AVCNFSM6AAAAABAEJU6QSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGI3TAMBUGQ . You are receiving this because you were mentioned.Message ID: @.***>

dodexahedron commented 9 months ago

Sounds great.

Looking forward to it. :)

It's a great tool for a great library, and I make plenty of use of both, so I'm more than happy to lend a hand. :)

dodexahedron commented 9 months ago

Oh, by the way...

If you're in Scotland, I come to you from the past (I'm 7 hours behind you).

And a fun little tidbit... I have a friend who used to live in Dundee but is now in Wormit, I think.

tznind commented 9 months ago

Its a fun place! Although a bit dreary at this time of year :)