Fix TOWER_TOP declaration for GCC10

gui11aume / starcode

All pairs search and sequence clustering

GNU General Public License v3.0

90 stars 21 forks source link

Fix TOWER_TOP declaration for GCC10 #39

Closed vejnar closed 3 years ago

vejnar commented 3 years ago

Compiling with GCC10 fails with error:

gcc -std=c99 -O3 -Wall -Wextra src/main-starcode.c src/trie.o src/starcode.o -lpthread -lm -o starcode
/usr/bin/ld: src/starcode.o:(.rodata+0x5c0): multiple definition of `TOWER_TOP'; src/trie.o:(.rodata+0x800): first defined here

This happens because TOWER_TOP is a global variable but not properly declared as such. See here.

Please consider for merging.

coveralls commented 3 years ago

Coverage remained the same at 50.641% when pulling a0041d17349b8426596e3f0500babb6c92852a3d on vejnar:gcc10 into 102dae28947d60dce14b583ee7b53a2460566b8e on gui11aume:master.

gui11aume commented 3 years ago

Hi @vejnar, this is awesome! Thanks so much for picking this up and going through the trouble of fixing it. I really appreciate it.