guiYMOUR / mindustry-Extra-Utilities-mod

Now start adapting to the new version
GNU General Public License v3.0
168 stars 27 forks source link

thorium reactor 2 is not in the campaign tech tree #38

Closed Rosnok closed 4 months ago

Rosnok commented 4 months ago

Mindustry_KBcCTkMqaf

i can see thorium reactor 2 in custom games but not in campaign tech tree, is this intended?

guiYMOUR commented 4 months ago
image
guiYMOUR commented 4 months ago

T2 Thorium Reactor: Sorry, maybe I don't look like myself...QAQ

Rosnok commented 4 months ago
image

Oh, apologies I used the wrong screenshot. I thought I had used the correct one, lol I should have double checked. I took that screenshot before I realized I only enabled Extra Utilities, I then proceeded to take another screenshot (that is below) with my current modlist enabled but forgot to upload it in the first place.

javaw_KezwAlvsUi But anyway, as you can see the Thorium Reactor II is missing in this tech tree, but after further troubleshooting while I was waiting for your response, I found out the culprit seems to be mod called Sapphirium.

I don't know how or why another mod affect one block being prevented to appear in tech tree, I have played with many mods with Extra Utilities (such as Exogenesis, New Horizons, Upgraded Tiers, Expanded Industries and more) and they worked just fine with it. But Sapphirium appears to have a minor incompatibility that prevent this certain block from appearing in the tech tree.

Screenshot below is when the aforementioned mod is disabled. javaw_zMHtdjTcOX

But if I disregard this, everything in Extra Utilities appears in the tech tree even with Sapphirium enabled. I just dont know why Thorium Reactor II refuses to appear when the former mod is enabled.

Rosnok commented 4 months ago

If this problem really reside on Sapphirium's side instead of Extra Utilities' side then I will report this issue to their mod's repository and have this issue here closed. I can't really tell which is which because I am not a very good programmer, apologies. I would like to hear your thoughts on this issue before concluding.

guiYMOUR commented 4 months ago

If he overwrites the original tech tree, then I'm sorry, I can't do anything because the mod reading order is beyond my control. I try not to use overwrite, but instead use add to ensure the compatibility of other mods.

guiYMOUR commented 4 months ago

Perhaps you can send me the source code address of this mod so that I can see what it is for

guiYMOUR commented 4 months ago

It seems that his tech trees are all covered......

Rosnok commented 4 months ago

Perhaps you can send me the source code address of this mod so that I can see what it is for

Sure, does this work for you? https://github.com/3Snake3/Sapphirium/tree/master

guiYMOUR commented 4 months ago

No, because he uploaded the compiled file, which is convenient for direct GitHub import...

guiYMOUR commented 4 months ago

I need to decompile it myself after downloading, TOO TROUBLESOME QAQ

guiYMOUR commented 4 months ago

anyway, I'll continue with my update work

I need to decompile it myself after downloading, TOO TROUBLESOME QAQ

Rosnok commented 4 months ago

No, because he uploaded the compiled file, which is convenient for direct GitHub import...

Hmmm.. I see, then I suppose this is unfixable on this side, it must be fixed on their side. Thanks for letting me take your time to explore this problem though.

Rosnok commented 4 months ago

I need to decompile it myself after downloading, TOO TROUBLESOME QAQ

anyway, I'll continue with my update work

I fully understand. It'd be a bit strange for another mod author to fix another one's mod lol, I'm not trying to impose anything just saying. I guess you shouldn't bother with it anymore then, I think it's best to focus on your mod :) I'll try to see this problem in Sapphirium's side then. With that being said, I will close this issue now that the problem cannot be really fixed if their mod doesn't have their source code exposed. Have a good day :)