Closed saeedmhanna1 closed 1 month ago
Dear Saeed,
Thanks for your message and for noticing an issue. I'll try to have a look.
Dear Saeed,
After some investigation, I think the issue comes from the fact that the resampled meteorological collection is not well sorted (from the older image to the most recent).
Please try to sort the collection and tell me if it's okay for you:
# Combine precipitation and evapotranspiration.
meteo = pr_m.combine(pet_m).sort("system:time_start")
Dear Mr. Attard,
While working with Saeed on my MSc project, I realized that there was another issue in the code.
The St in the recharge calculator function (line 1384) is prev.st. However it should be STfc in accordance with the reference Steenhuis and Van der Molen (1985).
Other than that, the code works well when sorting the meteo ImageCollection.
Thanks, Wilfried DATCHOUA.
Dear Wilfried,
Thanks for noticing. Indeed you are right about the error line 1384.
Do you have any other comment before I send the request to edit the tutorial to the product team?
Thanks,
Hi,
The tutorial has been updated regarding your comments: https://developers.google.com/earth-engine/tutorials/community/groundwater-recharge-estimation
Thanks for your contribution.
Hello, I've looked at your new code, and it seems to work perfectly. However, I was able to locate two errors that may be of interest to you. When I ran your code on shorter time steps (daily with a new function that transforms pentad data into days):
Therefore, I suggest replacing :
Yours sincerely, Wilfried DATCHOUA
Dear Mr. Attard,
While going throught the tutorial: "Implementation of the Thornthwaite-Mather procedure to map groundwater recharge", I noticed a few things:
There is an error with the of APWL equation in case 2.2, where it is missing a negative sign (the description not the code). Otherwise ln will return a negative number.
More importantly, I believe that there is an error when APWL is calculated. I tried doing the calculation manually using the equation described in the reference paper and got completely different values of recharge.
In the table showing APWL, p, pet, rech and st for 2015 for example, apwl rises from 0 to 527mm in march 2015, which makes absolutely no sense physically. Even when changing the scale to 500 (the original resolution of MODIS), the problem persists.
We can see the error clearly in the first year, we plot apwl against pet and pr in the charts.
Any feedback on that issue?
Thanks, Saeed