guibranco / PIX-BACEN-SDK-dotnet

🇧🇷 :bank: :gear: PIX/SPI contracts from @bacen/pix-api/
https://guibranco.github.io/PIX-BACEN-SDK-dotnet/
MIT License
20 stars 7 forks source link

Update Target Frameworks and Remove Tech Stack Files #118

Closed guibranco closed 2 weeks ago

guibranco commented 2 weeks ago

Description


Changes walkthrough 📝

Relevant files
Enhancement
PIXBacen.csproj
Update Target Frameworks in PIXBacen.csproj                           

Src/PIXBacen/PIXBacen.csproj
  • Updated target frameworks to include net8.0.
  • Maintained existing frameworks netstandard2.0, netstandard2.1, and
    net6.0.
  • +1/-1     
    PIXBacen.Tests.csproj
    Update Target Framework in PIXBacen.Tests.csproj                 

    Tests/PixBacen.Tests/PIXBacen.Tests.csproj
  • Updated target framework to net8.0.
  • Removed deprecated framework net7.0.
  • +1/-1     
    Other
    techstack.md
    Remove Tech Stack Documentation                                                   

    techstack.md
  • Deleted the tech stack documentation file.
  • Removed detailed tech stack information.
  • +0/-155 
    techstack.yml
    Remove Tech Stack Configuration                                                   

    techstack.yml
  • Deleted the tech stack configuration file.
  • Removed associated metadata.
  • +0/-194 
    penify-dev[bot] commented 2 weeks ago

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5] 2, because the changes are straightforward updates to target frameworks and the removal of outdated files, which do not require extensive review.
    🧪 Relevant tests No
    ⚡ Possible issues No
    🔒 Security concerns No
    penify-dev[bot] commented 2 weeks ago

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Ensure the test project is properly configured for the latest framework ___ **Ensure that the test project is configured to run with the latest framework to leverage
    new features and improvements.** [Tests/PixBacen.Tests/PIXBacen.Tests.csproj [5]](https://github.com/guibranco/PIX-BACEN-SDK-dotnet/pull/118/files#diff-4b0539c829c219ac1f7affbe3ac22c0e3eaae430259244ccf3978249c970ef51R5-R5) ```diff -net8.0 +net8.0 ```
    Suggestion importance[1-10]: 8 Why: This suggestion emphasizes the importance of leveraging new features in the latest framework, which is crucial for maintaining the test project’s effectiveness.
    8
    Possible issue
    Ensure compatibility of the new target frameworks with existing libraries ___ **Consider verifying the compatibility of the new target frameworks with existing libraries
    and dependencies to avoid runtime issues.** [Src/PIXBacen/PIXBacen.csproj [5]](https://github.com/guibranco/PIX-BACEN-SDK-dotnet/pull/118/files#diff-c4b232d865ea58295a58d400004259b4551a00fa16791121a01efb7b0bc766e3R5-R5) ```diff -netstandard2.0;netstandard2.1;net6.0;net8.0 +netstandard2.0;netstandard2.1;net6.0;net8.0 ```
    Suggestion importance[1-10]: 7 Why: This suggestion addresses potential runtime issues due to compatibility, which is important when changing target frameworks, but it does not directly change the code.
    7
    Check if the new target framework requires updates to test project dependencies ___ **It might be beneficial to check if the transition to net8.0 requires any updates to the
    test project dependencies or configurations.** [Tests/PixBacen.Tests/PIXBacen.Tests.csproj [5]](https://github.com/guibranco/PIX-BACEN-SDK-dotnet/pull/118/files#diff-4b0539c829c219ac1f7affbe3ac22c0e3eaae430259244ccf3978249c970ef51R5-R5) ```diff -net8.0 +net8.0 ```
    Suggestion importance[1-10]: 7 Why: This suggestion highlights the need to verify dependencies after changing the target framework, which is a good practice, but it does not involve a direct code change.
    7
    Maintainability
    Remove obsolete target frameworks to improve project maintainability ___ **Consider removing any obsolete target frameworks if they are no longer needed to keep the
    project clean and maintainable.** [Src/PIXBacen/PIXBacen.csproj [5]](https://github.com/guibranco/PIX-BACEN-SDK-dotnet/pull/118/files#diff-c4b232d865ea58295a58d400004259b4551a00fa16791121a01efb7b0bc766e3R5-R5) ```diff -netstandard2.0;netstandard2.1;net6.0;net8.0 +netstandard2.0;net6.0;net8.0 ```
    Suggestion importance[1-10]: 6 Why: While removing obsolete frameworks can improve maintainability, the suggestion does not reflect the current state of the code, which still includes necessary frameworks.
    6
    codacy-production[bot] commented 2 weeks ago

    Coverage summary from Codacy

    See diff coverage on Codacy

    Coverage variation Diff coverage
    :white_check_mark: +0.00% (target: -1.00%) :white_check_mark:
    Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (7cfe66113a69eb77897a9495c22fb6b3bc0afa67) | 75 | 1 | 1.33% | | | Head commit (13935ea5ca7faa3b0eda2a7f72a3cc6812510b39) | 75 (+0) | 1 (+0) | 1.33% (**+0.00%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
    Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#118) | 0 | 0 | **∅ (not applicable)** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

    See your quality gate settings    Change summary preferences

    Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

    sonarcloud[bot] commented 2 weeks ago

    Quality Gate Passed Quality Gate passed

    Issues
    0 New issues
    0 Accepted issues

    Measures
    0 Security Hotspots
    0.0% Coverage on New Code
    0.0% Duplication on New Code

    See analysis details on SonarCloud

    AppVeyorBot commented 2 weeks ago

    :white_check_mark: Build PIX-BACEN-SDK-dotnet 1.1.330 completed (commit https://github.com/guibranco/PIX-BACEN-SDK-dotnet/commit/d0424870dc by @guibranco)

    codecov[bot] commented 2 weeks ago

    Codecov Report

    All modified and coverable lines are covered by tests :white_check_mark:

    Project coverage is 1.33%. Comparing base (7cfe661) to head (13935ea). Report is 1 commits behind head on main.

    Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #118 +/- ## ===================================== Coverage 1.33% 1.33% ===================================== Files 17 17 Lines 75 75 ===================================== Hits 1 1 Misses 74 74 ```

    :umbrella: View full report in Codecov by Sentry.
    :loudspeaker: Have feedback on the report? Share it here.