Fix SC3010 - In POSIX sh, [[ ]] is undefined.

guibranco commented 1 week ago

📑 Description

✅ Checks

[X] My pull request adheres to the code style of this project
[X] My code requires changes to the documentation
[X] I have updated the documentation as required
[X] All the tests have passed

☢️ Does this introduce a breaking change?

[ ] Yes
[X] No

ℹ Additional Information

Summary by CodeRabbit

Chores
- Updated pre-commit hook script for improved branch name validation.
- Enhanced readability of the prepare-commit-msg script through formatting changes.

coderabbitai[bot] commented 1 week ago

Walkthrough

The changes in this pull request involve modifications to two pre-commit hook scripts: .githooks/pre-commit and .githooks/prepare-commit-msg. The .githooks/pre-commit script's interpreter has been changed to a more POSIX-compliant shell, and its branch name validation logic has been updated to use grep. The .githooks/prepare-commit-msg script has been reformatted for improved readability, including updates to comments and error handling, while maintaining its original functionality.

Changes

File Path	Change Summary
.githooks/pre-commit	Changed interpreter to `#!/usr/bin/env sh`. Updated branch name validation logic from `[[ ... ]]` to `grep -qE`. Removed a newline at the end of the file.
.githooks/prepare-commit-msg	Updated shebang to `#!/usr/bin/env sh`. Reformatted whitespace, line breaks, and comments for improved readability. Adjusted error handling for clarity.

Possibly related PRs

#14: This PR enhances the .githooks/prepare-commit-msg script, which is directly related to the changes made in the main PR regarding the same file.
#19: This PR modifies the logic in the .githooks/prepare-commit-msg script, which is relevant to the changes in the main PR that also involve this script.
#49: This PR includes updates to the .githooks/prepare-commit-msg script, enhancing its functionality, which relates to the changes made in the main PR.
#98: This PR updates the .githooks/prepare-commit-msg script, reflecting changes that are relevant to the modifications in the main PR.

Suggested labels

enhancement, size/S, Review effort [1-5]: 2, other

Suggested reviewers

gstraccini

Poem

🐰 In the code where bunnies hop,
Pre-commit scripts now take a stop.
With clearer lines and logic bright,
Our hooks are ready, oh what a sight!
So let us code with joy and cheer,
For every change brings us near! 🌟

[!WARNING]

Rate limit exceeded

@guibranco has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 24 seconds before requesting another review.

⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://docs.coderabbit.ai/faq) for further information.

📥 Commits
Reviewing files that changed from the base of the PR and between 50a40904bcc2901e7f1da0d9d326f6faef6fff03 and 536fe4ce92329f45d46258c541357ddc449dd8e1.

📜 Recent review details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

📥 Commits

Reviewing files that changed from the base of the PR and between 50a40904bcc2901e7f1da0d9d326f6faef6fff03 and 536fe4ce92329f45d46258c541357ddc449dd8e1.

📒 Files selected for processing (1)

* `.githooks/pre-commit` (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

* .githooks/pre-commit

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

deepsource-io[bot] commented 1 week ago

Here's the code health analysis summary for commits 91b9809..536fe4c. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Link
Shell	✅ Success	View Check ↗
Test coverage	✅ Success	View Check ↗
Secrets	✅ Success	View Check ↗
Docker	✅ Success	View Check ↗
C#	✅ Success	View Check ↗