Enhance pull request handling and update logic

[guibranco]

Description

• Introduced a compareUrl for better pull request comparison.
• Updated the updateBranch function to fetch and log the number of commits behind.
• Enhanced user feedback during branch updates based on comparison results.

---

Changes walkthrough 📝

	Relevant files
Enhancement	pullRequests.php Enhance pull request handling with comparison URL and branch update logic Src/pullRequests.php Added a new compareUrl to the pull request data. Enhanced the updateBranch function to check the number of commits behind. Improved logging for branch update status based on comparison results. +12/-6

[penify-dev[bot]]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	3, because the changes involve enhancements to existing functionality and require understanding of the pull request handling logic.
🧪 Relevant tests	No
⚡ Possible issues	Possible Bug: The `compareUrl` construction assumes that the `$repoPrefix` is always valid. If it is not set correctly, it could lead to incorrect URLs.
	Possible Bug: The response from `doRequestGitHub` is not checked for errors before accessing `$compare->behind_by`, which could lead to undefined property errors if the request fails.
🔒 Security concerns	No

[deepsource-io[bot]]

Here's the code health analysis summary for commits da89a88..e010c87. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Docker	✅ Success		View Check ↗
PHP	✅ Success		View Check ↗
Secrets	✅ Success		View Check ↗
SQL	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[penify-dev[bot]]

PR Code Suggestions ✨

Category	Suggestion	Score
Security	Add error handling for the GitHub request to ensure robustness ___ **Ensure that the doRequestGitHub function handles potential errors from the API call to avoid unhandled exceptions.** [Src/pullRequests.php [397]](https://github.com/guibranco/gstraccini-bot/pull/465/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R397-R397) ```diff -doRequestGitHub($metadata["token"], $url, $body, "PUT"); +$response = doRequestGitHub($metadata["token"], $url, $body, "PUT"); +if (!$response || $response->status !== 200) { + echo "Error updating branch: " . ($response->message ?? 'Unknown error') . "\n"; + return; +} ``` Suggestion importance[1-10]: 10 Why: This suggestion is crucial as it adds error handling for API calls, which is essential for robustness and preventing unhandled exceptions in the application.	10
Possible bug	Validate the structure of the compare response to prevent accessing undefined properties ___ **Check if the compareResponse is valid and contains the expected structure before accessing its properties to avoid potential errors.** [Src/pullRequests.php [387]](https://github.com/guibranco/gstraccini-bot/pull/465/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R387-R387) ```diff -$compare = json_decode($compareResponse->body, true); +$compare = json_decode($compareResponse->body, true) ?? []; +if (!isset($compare['behind_by'])) { + echo "Error: Invalid compare response structure.\n"; + return; +} ``` Suggestion importance[1-10]: 9 Why: This suggestion addresses a potential bug by ensuring that the response structure is validated before accessing its properties, which is crucial for avoiding runtime errors.	9
Possible issue	Validate the presence of base and head references when forming the compare URL ___ **Ensure that the compareUrl is correctly formed by validating the presence of the base and head references before constructing the URL.** [Src/pullRequests.php [43]](https://github.com/guibranco/gstraccini-bot/pull/465/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R43-R43) ```diff -"compareUrl" => $repoPrefix . "/compare/", +"compareUrl" => isset($pullRequestUpdated->base->ref) && isset($pullRequestUpdated->head->ref) ? $repoPrefix . "/compare/" : null, ``` Suggestion importance[1-10]: 7 Why: While validating the presence of base and head references is a good practice, the suggestion does not address a critical issue since the URL construction is straightforward and the absence of references would likely lead to a null value rather than a runtime error.	7
Maintainability	Enhance the clarity of the output messages related to branch updates ___ **Consider using a more descriptive message for the echo statements to improve clarity on the branch update process.** [Src/pullRequests.php [390]](https://github.com/guibranco/gstraccini-bot/pull/465/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R390-R390) ```diff -echo "State: {$pullRequestUpdated->mergeable_state} - Commits Behind: 0 - Updating branch: No - Sender: {$pullRequestUpdated->user->login} 👎🏻\n"; +echo "Pull Request is up-to-date. No updates needed for branch: {$pullRequestUpdated->user->login} 👎🏻\n"; ``` Suggestion importance[1-10]: 5 Why: While improving message clarity is beneficial for maintainability, this suggestion does not address a critical issue and is more of a stylistic improvement.	5

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions[bot]]

Infisical secrets check: :white_check_mark: No secrets leaked!

Scan results:

8:51PM INF scanning for exposed secrets...
8:51PM INF 404 commits scanned.
8:51PM INF scan completed in 115ms
8:51PM INF no leaks found