Improve label deletion handling in branches.php

[guibranco]

Description

• Enhanced the handling of label deletion by ensuring proper URL encoding.
• Fixed a syntax error in the doRequestGitHub function call.

---

Changes walkthrough 📝

	Relevant files
Enhancement	branches.php Improve label deletion handling in branches.php                    src/branches.php Updated URL encoding for label deletion. Fixed a syntax error in the function call. +2/-1

[deepsource-io[bot]]

Here's the code health analysis summary for commits dc875a9..4b78a56. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Docker	✅ Success		View Check ↗
PHP	✅ Success		View Check ↗
Secrets	✅ Success		View Check ↗
SQL	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[penify-dev[bot]]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the changes are straightforward and involve minor adjustments to URL handling and a syntax fix.
🧪 Relevant tests	No
⚡ Possible issues	Syntax Error: There is a missing comma in the `doRequestGitHub` function call after the `$url` variable.
🔒 Security concerns	No

[penify-dev[bot]]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible bug	Fix the syntax error by adding a comma in the function call ___ **The doRequestGitHub function call is missing a comma before the null argument, which will cause a syntax error.** [Src/branches.php [79]](https://github.com/guibranco/gstraccini-bot/pull/500/files#diff-1bbdf1b5eb76ae63d5bc2c3cfc8faaba7aed32dcb4bd6010377dc5cb61855c71R79-R79) ```diff -doRequestGitHub($metadata["token"], $url null, "DELETE"); +doRequestGitHub($metadata["token"], $url, null, "DELETE"); ``` Suggestion importance[1-10]: 10 Why: This suggestion addresses a critical syntax error that would prevent the code from executing properly.	10
Possible issue	Add a check to ensure the URL is not empty before making the request ___ **Ensure that the doRequestGitHub function handles the case where the URL is empty or invalid, to prevent potential errors during execution.** [Src/branches.php [79]](https://github.com/guibranco/gstraccini-bot/pull/500/files#diff-1bbdf1b5eb76ae63d5bc2c3cfc8faaba7aed32dcb4bd6010377dc5cb61855c71R79-R79) ```diff -doRequestGitHub($metadata["token"], $url, null, "DELETE"); +if (!empty($url)) { doRequestGitHub($metadata["token"], $url, null, "DELETE"); } ``` Suggestion importance[1-10]: 8 Why: This suggestion improves the robustness of the code by preventing potential runtime errors, making it a valuable addition.	8
Best practice	Validate the issue URL to ensure it is correctly formatted before usage ___ **Consider validating the issueUrl in the $metadata array to ensure it is properly formatted before using it in the URL construction.** [Src/branches.php [78]](https://github.com/guibranco/gstraccini-bot/pull/500/files#diff-1bbdf1b5eb76ae63d5bc2c3cfc8faaba7aed32dcb4bd6010377dc5cb61855c71R78-R78) ```diff -$url = $metadata["issueUrl"] . "/labels/" . urlencode("🛠 WIP"); +$url = filter_var($metadata["issueUrl"], FILTER_VALIDATE_URL) ? $metadata["issueUrl"] . "/labels/" . urlencode("🛠 WIP") : ''; ``` Suggestion importance[1-10]: 7 Why: Validating the URL is a good practice that can prevent potential issues, though it is not critical for the current functionality.	7
Enhancement	Log the response from the delete request for better debugging ___ **Consider logging the response from doRequestGitHub to help with debugging and tracking the outcome of the delete operation.** [Src/branches.php [79]](https://github.com/guibranco/gstraccini-bot/pull/500/files#diff-1bbdf1b5eb76ae63d5bc2c3cfc8faaba7aed32dcb4bd6010377dc5cb61855c71R79-R79) ```diff -doRequestGitHub($metadata["token"], $url, null, "DELETE"); +$response = doRequestGitHub($metadata["token"], $url, null, "DELETE"); error_log($response); ``` Suggestion importance[1-10]: 6 Why: While logging is beneficial for debugging, it is more of an enhancement than a necessity, hence the lower score.	6

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions[bot]]

Infisical secrets check: :white_check_mark: No secrets leaked!

Scan results:

10:27PM INF scanning for exposed secrets...
10:27PM INF 437 commits scanned.
10:27PM INF scan completed in 117ms
10:27PM INF no leaks found