Enhance URL handling for WIP label removal in pullRequests.php

[guibranco]

Description

• Enhanced the URL handling for removing the WIP label by using urlencode to ensure proper encoding of special characters.
• This change improves the robustness of the removeIssueWipLabel function.

---

Changes walkthrough 📝

	Relevant files
Enhancement	pullRequests.php Enhance URL handling for WIP label removal                              Src/pullRequests.php Updated the URL encoding for the WIP label. Improved handling of special characters in the label name. +1/-1

[deepsource-io[bot]]

Here's the code health analysis summary for commits a3adc23..d97d437. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Docker	✅ Success		View Check ↗
PHP	✅ Success		View Check ↗
Secrets	✅ Success		View Check ↗
SQL	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[penify-dev[bot]]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the change is straightforward and involves a single line modification for URL encoding.
🧪 Relevant tests	No
⚡ Possible issues	No
🔒 Security concerns	No

[penify-dev[bot]]

PR Code Suggestions ✨

Category	Suggestion	Score
Error handling	Enhance error handling for the DELETE request to manage exceptions effectively ___ **Ensure that doRequestGitHub handles possible exceptions or errors when making the DELETE request to improve error handling.** [Src/pullRequests.php [254]](https://github.com/guibranco/gstraccini-bot/pull/501/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R254-R254) ```diff -doRequestGitHub($metadata["token"], $url, null, "DELETE"); +try { + doRequestGitHub($metadata["token"], $url, null, "DELETE"); +} catch (Exception $e) { + // Handle exception appropriately +} ``` Suggestion importance[1-10]: 9 Why: This suggestion significantly enhances the error handling of the DELETE request, which is crucial for robust application behavior, making it a high-priority improvement.	9
Best practice	Improve URL encoding for the WIP label to handle special characters ___ **Ensure that the urlencode function is applied to the entire label string to handle any special characters correctly.** [Src/pullRequests.php [253]](https://github.com/guibranco/gstraccini-bot/pull/501/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R253-R253) ```diff +$url = $metadata["issuesUrl"] . "/" . $issueNumber . "/labels/" . urlencode("🛠 WIP"); - ``` Suggestion importance[1-10]: 8 Why: The suggestion correctly identifies the need for URL encoding, which is crucial for handling special characters in URLs, thus improving the robustness of the code.	8
Possible issue	Add checks for the existence of required keys in the metadata array before constructing the URL ___ **Consider checking if issuesUrl and issueNumber are set in the metadata array before constructing the URL to avoid potential undefined index errors.** [Src/pullRequests.php [252-253]](https://github.com/guibranco/gstraccini-bot/pull/501/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R252-R253) ```diff -$url = $metadata["issuesUrl"] . "/" . $issueNumber . "/labels/" . urlencode("🛠 WIP"); +if (isset($metadata["issuesUrl"], $issueNumber)) { + $url = $metadata["issuesUrl"] . "/" . $issueNumber . "/labels/" . urlencode("🛠 WIP"); +} ``` Suggestion importance[1-10]: 7 Why: This suggestion addresses a potential issue with undefined indices, which is important for preventing runtime errors, but it is not critical since the current implementation may still work under normal conditions.	7
Maintainability	Use a constant for the WIP label to improve maintainability and reduce errors ___ **Consider using a constant for the WIP label string to avoid hardcoding and potential typos.** [Src/pullRequests.php [253]](https://github.com/guibranco/gstraccini-bot/pull/501/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R253-R253) ```diff -$url = $metadata["issuesUrl"] . "/" . $issueNumber . "/labels/" . urlencode("🛠 WIP"); +define('WIP_LABEL', "🛠 WIP"); +$url = $metadata["issuesUrl"] . "/" . $issueNumber . "/labels/" . urlencode(WIP_LABEL); ``` Suggestion importance[1-10]: 6 Why: Using a constant for the WIP label improves maintainability and reduces the risk of typos, but it is a minor improvement compared to the other suggestions.	6

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions[bot]]

Infisical secrets check: :white_check_mark: No secrets leaked!

Scan results:

5:28PM INF scanning for exposed secrets...
5:28PM INF 436 commits scanned.
5:28PM INF scan completed in 121ms
5:28PM INF no leaks found