Simplify label deletion process in issues.php

[guibranco]

Description

• Improved the removeLabels function by removing the unnecessary urlencode for labels.
• This change simplifies the process of deleting labels from issues.

---

Changes walkthrough 📝

	Relevant files
Enhancement	issues.php Simplify label deletion in issues.php                                        src/issues.php Removed unnecessary URL encoding for labels. Simplified the label deletion process. +0/-1

[deepsource-io[bot]]

Here's the code health analysis summary for commits a5ba202..c0fad1f. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Docker	✅ Success		View Check ↗
PHP	✅ Success		View Check ↗
Secrets	✅ Success		View Check ↗
SQL	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[penify-dev[bot]]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	1, because the change is straightforward and involves a simple removal of a line of code.
🧪 Relevant tests	No
⚡ Possible issues	No
🔒 Security concerns	No

[penify-dev[bot]]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible issue	Implement error handling for the response from the DELETE request ___ **Consider checking the response from doRequestGitHub to handle any potential errors during the label deletion process.** [Src/issues.php [87]](https://github.com/guibranco/gstraccini-bot/pull/502/files#diff-6ce0dad4f38891d2e6067af9734b44466fa59d01ddc1ebde9197a21430ec7c4eR87-R87) ```diff -doRequestGitHub($metadata["token"], $url, null, "DELETE"); +$response = doRequestGitHub($metadata["token"], $url, null, "DELETE"); +if ($response['status'] !== 204) { /* handle error */ } ``` Suggestion importance[1-10]: 9 Why: This suggestion improves error handling, which is essential for robust code, especially when dealing with external API requests.	9
Possible bug	Add URL encoding for the label to prevent issues with special characters ___ **Ensure that the label is properly URL-encoded to handle special characters, which could lead to issues when making the DELETE request.** [Src/issues.php [86]](https://github.com/guibranco/gstraccini-bot/pull/502/files#diff-6ce0dad4f38891d2e6067af9734b44466fa59d01ddc1ebde9197a21430ec7c4eR86-R86) ```diff -$url = "{$metadata["issueUrl"]}/labels/{$label}"; +$url = "{$metadata["issueUrl"]}/labels/" . urlencode($label); ``` Suggestion importance[1-10]: 8 Why: The suggestion addresses a potential bug by ensuring that special characters in labels are properly encoded, which is crucial for the DELETE request to function correctly.	8
Best practice	Add validation for the issue URL to ensure it is a valid format ___ **Validate that $metadata["issueUrl"] is a valid URL before using it to construct the DELETE request.** [Src/issues.php [86]](https://github.com/guibranco/gstraccini-bot/pull/502/files#diff-6ce0dad4f38891d2e6067af9734b44466fa59d01ddc1ebde9197a21430ec7c4eR86-R86) ```diff -$url = "{$metadata["issueUrl"]}/labels/{$label}"; +if (filter_var($metadata["issueUrl"], FILTER_VALIDATE_URL) === false) { /* handle invalid URL */ } +$url = "{$metadata["issueUrl"]}/labels/" . urlencode($label); ``` Suggestion importance[1-10]: 7 Why: Validating the URL is a good practice to prevent runtime errors, although it may not be as critical as the previous suggestions.	7
Maintainability	Rename the variable to enhance code clarity ___ **Consider using a more descriptive variable name for $intersect to improve code readability.** [Src/issues.php [83]](https://github.com/guibranco/gstraccini-bot/pull/502/files#diff-6ce0dad4f38891d2e6067af9734b44466fa59d01ddc1ebde9197a21430ec7c4eR83-R83) ```diff -$intersect = array_intersect($labelsLookup, $labels); +$commonLabels = array_intersect($labelsLookup, $labels); ``` Suggestion importance[1-10]: 5 Why: While improving variable names enhances readability, this change is more about style than functionality, making it less critical compared to other suggestions.	5

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions[bot]]

Infisical secrets check: :white_check_mark: No secrets leaked!

Scan results:

10:36PM INF scanning for exposed secrets...
10:36PM INF 438 commits scanned.
10:36PM INF scan completed in 118ms
10:36PM INF no leaks found