Improve URL handling for WIP label removal in pullRequests.php

[guibranco]

Description

• Enhanced the removeIssueWipLabel function to improve URL handling.
• The WIP label is now directly included in the URL without encoding.

---

Changes walkthrough 📝

	Relevant files
Enhancement	pullRequests.php Improve URL handling for WIP label removal                              Src/pullRequests.php Updated the URL construction for removing WIP labels. Changed the way the label is encoded in the URL. +1/-1

[deepsource-io[bot]]

Here's the code health analysis summary for commits 4eee88b..143adf0. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Docker	✅ Success		View Check ↗
PHP	✅ Success		View Check ↗
Secrets	✅ Success		View Check ↗
SQL	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[penify-dev[bot]]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the changes are straightforward and involve a simple URL modification.
🧪 Relevant tests	No
⚡ Possible issues	Possible Bug: Directly including the WIP label in the URL may lead to issues if the label contains special characters that need to be handled differently.
🔒 Security concerns	No

[penify-dev[bot]]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible bug	Ensure proper URL encoding for the WIP label in the URL construction ___ **Use urlencode to ensure the URL is properly encoded, especially for special characters like "🛠".** [Src/pullRequests.php [253]](https://github.com/guibranco/gstraccini-bot/pull/503/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R253-R253) ```diff -$url = $metadata["issuesUrl"] . "/" . $issueNumber . "/labels/🛠 WIP"; +$url = $metadata["issuesUrl"] . "/" . $issueNumber . "/labels/" . urlencode("🛠 WIP"); ``` Suggestion importance[1-10]: 10 Why: This suggestion addresses a potential bug by ensuring that the URL is properly encoded, which is crucial for handling special characters correctly.	10
Possible issue	Add error handling for the response from the GitHub request to improve robustness ___ **Ensure that the response from doRequestGitHub is checked for success or failure to handle potential errors.** [Src/pullRequests.php [254]](https://github.com/guibranco/gstraccini-bot/pull/503/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R254-R254) ```diff -doRequestGitHub($metadata["token"], $url, null, "DELETE"); +$response = doRequestGitHub($metadata["token"], $url, null, "DELETE"); +if (!$response) { + // Handle error +} ``` Suggestion importance[1-10]: 9 Why: This suggestion significantly improves the robustness of the code by adding error handling for the GitHub request, which is essential for reliable operation.	9
Maintainability	Add validation for required metadata keys to prevent runtime errors ___ **Validate that issuesUrl and issueNumber are set in $metadata to avoid potential undefined index errors.** [Src/pullRequests.php [252-253]](https://github.com/guibranco/gstraccini-bot/pull/503/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R252-R253) ```diff -$url = $metadata["issuesUrl"] . "/" . $issueNumber . "/labels/🛠 WIP"; +if (isset($metadata["issuesUrl"], $issueNumber)) { + $url = $metadata["issuesUrl"] . "/" . $issueNumber . "/labels/" . urlencode("🛠 WIP"); +} ``` Suggestion importance[1-10]: 8 Why: This suggestion improves the robustness of the code by preventing runtime errors due to undefined indices, which is important for maintainability.	8
Best practice	Replace the hardcoded WIP label with a variable for better maintainability ___ **Consider using a constant or configuration for the WIP label to avoid hardcoding the string in multiple places.** [Src/pullRequests.php [253]](https://github.com/guibranco/gstraccini-bot/pull/503/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R253-R253) ```diff -$url = $metadata["issuesUrl"] . "/" . $issueNumber . "/labels/🛠 WIP"; +$wipLabel = "🛠 WIP"; +$url = $metadata["issuesUrl"] . "/" . $issueNumber . "/labels/" . urlencode($wipLabel); ``` Suggestion importance[1-10]: 7 Why: This suggestion enhances maintainability by avoiding hardcoded strings, although it is not critical to the functionality of the code.	7

[github-actions[bot]]

Infisical secrets check: :white_check_mark: No secrets leaked!

Scan results:

10:31PM INF scanning for exposed secrets...
10:31PM INF 438 commits scanned.
10:31PM INF scan completed in 118ms
10:31PM INF no leaks found

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud