Enhance branch reference handling in pullRequests.php

[guibranco]

Description

• Enhanced the updateBranch function to use urlencode() for baseRef and headRef.
• This change improves the handling of branch references, ensuring proper URL encoding.

---

Changes walkthrough 📝

	Relevant files
Enhancement	pullRequests.php Enhance branch reference handling in updateBranch function Src/pullRequests.php Updated baseRef and headRef to use urlencode(). Improved handling of branch references in the updateBranch function. +2/-2

[penify-dev[bot]]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the changes are straightforward and involve a simple enhancement to existing functionality with minimal complexity.
🧪 Relevant tests	No
⚡ Possible issues	No
🔒 Security concerns	No

[deepsource-io[bot]]

Here's the code health analysis summary for commits 9fe8dee..6a46322. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Docker	✅ Success		View Check ↗
PHP	✅ Success		View Check ↗
Secrets	✅ Success		View Check ↗
SQL	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions[bot]]

Infisical secrets check: :white_check_mark: No secrets leaked!

Scan results:

10:12PM INF scanning for exposed secrets...
10:12PM INF 405 commits scanned.
10:12PM INF scan completed in 123ms
10:12PM INF no leaks found

[penify-dev[bot]]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible issue	Validate the existence of base and head properties to avoid potential runtime errors ___ **Consider validating that base and head properties exist on the $pullRequestUpdated object to prevent runtime errors.** [Src/pullRequests.php [381-384]](https://github.com/guibranco/gstraccini-bot/pull/467/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R381-R384) ```diff -$baseRef = urlencode($pullRequestUpdated->base->ref); -$headRef = urlencode($pullRequestUpdated->head->ref); +if (isset($pullRequestUpdated->base->ref) && isset($pullRequestUpdated->head->ref)) { + $baseRef = urlencode($pullRequestUpdated->base->ref); + $headRef = urlencode($pullRequestUpdated->head->ref); +} else { + // Handle the error or set default values +} ``` Suggestion importance[1-10]: 9 Why: Validating the existence of properties is crucial to prevent runtime errors, making this a significant improvement to the code's reliability.	9
	Add error handling for the response from doRequestGitHub to ensure robustness ___ **Ensure that the response from doRequestGitHub is checked for errors before proceeding to decode it.** [Src/pullRequests.php [386-387]](https://github.com/guibranco/gstraccini-bot/pull/467/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R386-R387) ```diff $compareResponse = doRequestGitHub($metadata["token"], "{$metadata["compareUrl"]}{$baseRef}...{$headRef}", null, "GET"); +if ($compareResponse->status !== 200) { + // Handle error appropriately +} $compare = json_decode($compareResponse->body); ``` Suggestion importance[1-10]: 9 Why: Adding error handling for the API response is essential for robustness, making this suggestion highly valuable for maintaining code quality.	9
	Add null checks before applying urlencode to prevent potential errors ___ **Ensure that the urlencode function is applied to both $baseRef and $headRef only if they are not null to avoid potential warnings or errors.** [Src/pullRequests.php [383-384]](https://github.com/guibranco/gstraccini-bot/pull/467/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R383-R384) ```diff -$baseRef = urlencode($pullRequestUpdated->base->ref); -$headRef = urlencode($pullRequestUpdated->head->ref); +$baseRef = $pullRequestUpdated->base->ref ? urlencode($pullRequestUpdated->base->ref) : null; +$headRef = $pullRequestUpdated->head->ref ? urlencode($pullRequestUpdated->head->ref) : null; ``` Suggestion importance[1-10]: 8 Why: This suggestion addresses a potential issue with null values that could lead to warnings, improving the robustness of the code.	8
Maintainability	Rename the variable to enhance code readability and clarity ___ **Consider using a more descriptive variable name for $compareResponse to clarify its purpose.** [Src/pullRequests.php [386]](https://github.com/guibranco/gstraccini-bot/pull/467/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R386-R386) ```diff -$compareResponse = doRequestGitHub($metadata["token"], "{$metadata["compareUrl"]}{$baseRef}...{$headRef}", null, "GET"); +$comparisonResponse = doRequestGitHub($metadata["token"], "{$metadata["compareUrl"]}{$baseRef}...{$headRef}", null, "GET"); ``` Suggestion importance[1-10]: 5 Why: While improving variable naming enhances readability, this change is more of a style suggestion and does not address critical functionality.	5