Enhance error handling in pullRequests.php

[guibranco]

Description

• Introduced error handling for the GitHub API response in the updateBranch function.
• The function now returns early if the API response status code is 300 or higher, preventing further processing.

---

Changes walkthrough 📝

	Relevant files
Error handling	pullRequests.php Enhance error handling for GitHub API response                      Src/pullRequests.php Added a check for the response status code from the GitHub API. If the status code is 300 or higher, the function will return early. +3/-0

[penify-dev[bot]]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the changes are straightforward and involve a simple error handling enhancement.
🧪 Relevant tests	No
⚡ Possible issues	No
🔒 Security concerns	No

[deepsource-io[bot]]

Here's the code health analysis summary for commits 7139cbe..8efed18. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Docker	✅ Success		View Check ↗
PHP	✅ Success		View Check ↗
Secrets	✅ Success		View Check ↗
SQL	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions[bot]]

Infisical secrets check: :white_check_mark: No secrets leaked!

Scan results:

10:50PM INF scanning for exposed secrets...
10:50PM INF 406 commits scanned.
10:50PM INF scan completed in 117ms
10:50PM INF no leaks found

[penify-dev[bot]]

PR Code Suggestions ✨

Category	Suggestion	Score
Error handling	Improve error handling by throwing an exception for non-successful status codes ___ **Instead of returning silently when the status code is 300 or higher, consider throwing an exception or logging the error to provide better visibility into the failure.** [Src/pullRequests.php [387-389]](https://github.com/guibranco/gstraccini-bot/pull/468/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R387-R389) ```diff if ($compareResponse->statusCode >= 300) { - return; + throw new Exception("Error fetching compare response: " . $compareResponse->statusCode); } ``` Suggestion importance[1-10]: 9 Why: This suggestion improves error handling significantly by providing a mechanism to alert the developer of an issue, rather than failing silently.	9
	Add error handling for JSON decoding to catch parsing issues ___ **Check if `json_decode` returns `null` to handle potential JSON parsing errors gracefully.** [Src/pullRequests.php [390]](https://github.com/guibranco/gstraccini-bot/pull/468/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R390-R390) ```diff $compare = json_decode($compareResponse->body); +if (json_last_error() !== JSON_ERROR_NONE) { + throw new Exception("JSON decoding error: " . json_last_error_msg()); +} ``` Suggestion importance[1-10]: 8 Why: This suggestion addresses potential issues with JSON parsing, which can lead to unexpected behavior if not handled properly.	8
Logging	Enhance error visibility by logging the status code and response body on error ___ **Consider logging the status code and response body for debugging purposes when an error occurs.** [Src/pullRequests.php [387-389]](https://github.com/guibranco/gstraccini-bot/pull/468/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R387-R389) ```diff if ($compareResponse->statusCode >= 300) { + error_log("Error fetching compare response: " . $compareResponse->statusCode . " - " . $compareResponse->body); return; } ``` Suggestion importance[1-10]: 8 Why: Logging the status code and response body enhances visibility into errors, which is important for debugging, but it may not be as critical as throwing an exception.	8
Maintainability	Validate that $compareResponse is an object before accessing its properties ___ **Ensure that $compareResponse is an object before accessing its properties to avoid potential errors.** [Src/pullRequests.php [387]](https://github.com/guibranco/gstraccini-bot/pull/468/files#diff-a02ee044998cfd579cf9d812f74b51f079e912308e6ce6d9c1337620894ec463R387-R387) ```diff -if ($compareResponse->statusCode >= 300) { +if (is_object($compareResponse) && $compareResponse->statusCode >= 300) { ``` Suggestion importance[1-10]: 7 Why: Validating that `$compareResponse` is an object before accessing its properties is a good practice to prevent runtime errors, although it may not be critical if the response is always expected to be an object.	7