Enhance comments handling in comments.php

[guibranco]

Description

• Enhanced the regex pattern to allow more characters in the issue copy command.
• Updated the URL used in the GitHub request to check for open pull requests.
• Added a check to ensure the pull request exists in the response.

---

Changes walkthrough 📝

	Relevant files
Enhancement	comments.php Enhance issue copy command and GitHub request handling      Src/comments.php Updated regex pattern for issue copying command. Changed GitHub request URL from pull request to issue URL. Added validation for the presence of pull request in response. +6/-2

[deepsource-io[bot]]

Here's the code health analysis summary for commits 4b1aab0..1126e5a. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Docker	✅ Success		View Check ↗
PHP	✅ Success		View Check ↗
Secrets	✅ Success		View Check ↗
SQL	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[penify-dev[bot]]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the changes are straightforward and primarily involve regex and URL updates, which are not complex.
🧪 Relevant tests	No
⚡ Possible issues	Possible Bug: The regex pattern change may inadvertently allow unwanted characters if not properly validated.
🔒 Security concerns	No

[penify-dev[bot]]

PR Code Suggestions ✨

Category	Suggestion	Score
Best practice	Add error handling for the GitHub request to prevent runtime exceptions ___ **Ensure that the doRequestGitHub function handles potential exceptions or errors when making the request to avoid runtime errors.** [Src/comments.php [505]](https://github.com/guibranco/gstraccini-bot/pull/482/files#diff-c016a4b724b06cf94f3e5e764ca4f4eb4d42b550ddca3566f9b03c2f3bec51faR505-R505) ```diff -$pullRequestResponse = doRequestGitHub($metadata["token"], $metadata["issueUrl"], null, "GET"); +try { + $pullRequestResponse = doRequestGitHub($metadata["token"], $metadata["issueUrl"], null, "GET"); +} catch (Exception $e) { + return false; +} ``` Suggestion importance[1-10]: 9 Why: Adding error handling for the GitHub request is crucial to prevent runtime exceptions, making the code more robust and reliable.	9
Possible issue	Improve regex pattern to safely handle special characters in the bot name ___ **The regex pattern should be updated to ensure it captures the intended format correctly, especially if the bot name can contain special characters.** [Src/comments.php [287]](https://github.com/guibranco/gstraccini-bot/pull/482/files#diff-c016a4b724b06cf94f3e5e764ca4f4eb4d42b550ddca3566f9b03c2f3bec51faR287-R287) ```diff -"/@" . $config->botName . "\scopy\sissue\s([a-zA-Z0-9_.-]+)\/([a-zA-Z0-9_.-]+)/" +"/@" . preg_quote($config->botName, '/') . "\scopy\sissue\s([a-zA-Z0-9_.-]+)\/([a-zA-Z0-9_.-]+)/" ``` Suggestion importance[1-10]: 8 Why: The suggestion improves the regex pattern to safely handle special characters in the bot name, which is important for ensuring the correct functionality of the command parsing.	8
Possible bug	Enhance validation for the pull request object to ensure required properties exist ___ **The check for the pull request should also validate that the pull_request object contains the expected properties to avoid potential errors when accessing them.** [Src/comments.php [511]](https://github.com/guibranco/gstraccini-bot/pull/482/files#diff-c016a4b724b06cf94f3e5e764ca4f4eb4d42b550ddca3566f9b03c2f3bec51faR511-R511) ```diff -if (!isset($pullRequest->pull_request)) { +if (!isset($pullRequest->pull_request) || !isset($pullRequest->head->ref) || !isset($pullRequest->head->sha)) { ``` Suggestion importance[1-10]: 7 Why: Enhancing validation for the pull request object is a good practice to prevent potential errors, though it addresses a minor issue compared to the previous suggestions.	7
Maintainability	Rename the variable for clarity regarding its content and purpose ___ **Consider using a more descriptive variable name for $pullRequestResponse to clarify its purpose in the context of the function.** [Src/comments.php [505]](https://github.com/guibranco/gstraccini-bot/pull/482/files#diff-c016a4b724b06cf94f3e5e764ca4f4eb4d42b550ddca3566f9b03c2f3bec51faR505-R505) ```diff -$pullRequestResponse = doRequestGitHub($metadata["token"], $metadata["issueUrl"], null, "GET"); +$responseFromGitHub = doRequestGitHub($metadata["token"], $metadata["issueUrl"], null, "GET"); ``` Suggestion importance[1-10]: 5 Why: While renaming the variable for clarity is beneficial for maintainability, it does not address a critical issue and is more of a stylistic improvement.	5

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions[bot]]

Infisical secrets check: :white_check_mark: No secrets leaked!

Scan results:

11:16PM INF scanning for exposed secrets...
11:16PM INF 423 commits scanned.
11:16PM INF scan completed in 117ms
11:16PM INF no leaks found