Enhance label deletion in issues.php

[guibranco]

Description

• Enhanced the removeLabels function to URL encode label names before making DELETE requests.
• This change ensures that labels with special characters are handled correctly.

---

Changes walkthrough 📝

	Relevant files
Enhancement	issues.php Enhance label deletion by URL encoding                                      src/issues.php Added URL encoding for labels before deletion. Ensured proper handling of special characters in label names. +1/-0

[deepsource-io[bot]]

Here's the code health analysis summary for commits c6a6a1f..e1b9ee3. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Docker	✅ Success		View Check ↗
PHP	✅ Success		View Check ↗
Secrets	✅ Success		View Check ↗
SQL	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[penify-dev[bot]]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the change is straightforward and involves a simple URL encoding addition without complex logic.
🧪 Relevant tests	No
⚡ Possible issues	No
🔒 Security concerns	No

[github-actions[bot]]

Infisical secrets check: :white_check_mark: No secrets leaked!

Scan results:

3:23PM INF scanning for exposed secrets...
3:23PM INF 434 commits scanned.
3:23PM INF scan completed in 120ms
3:23PM INF no leaks found

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[penify-dev[bot]]

PR Code Suggestions ✨

Category	Suggestion	Score
Maintainability	Implement error handling for the DELETE request to log failures and improve debugging ___ **Consider handling potential errors from the doRequestGitHub function to ensure that any issues during the DELETE request are properly logged or managed.** [Src/issues.php [88]](https://github.com/guibranco/gstraccini-bot/pull/498/files#diff-6ce0dad4f38891d2e6067af9734b44466fa59d01ddc1ebde9197a21430ec7c4eR88-R88) ```diff -doRequestGitHub($metadata["token"], $url, null, "DELETE"); +$response = doRequestGitHub($metadata["token"], $url, null, "DELETE"); +if ($response === false) { + error_log("Failed to delete label at URL: $url"); +} ``` Suggestion importance[1-10]: 9 Why: Implementing error handling for the DELETE request is crucial for debugging and maintaining the application, making this a strong suggestion.	9
Best practice	Validate the constructed URL to ensure it is well-formed before proceeding with the API request ___ **Consider checking if the url variable is properly formed before making the DELETE request to avoid unnecessary API calls with invalid URLs.** [Src/issues.php [87]](https://github.com/guibranco/gstraccini-bot/pull/498/files#diff-6ce0dad4f38891d2e6067af9734b44466fa59d01ddc1ebde9197a21430ec7c4eR87-R87) ```diff $url = "{$metadata["issueUrl"]}/labels/{$label}"; +if (filter_var($url, FILTER_VALIDATE_URL) === false) { + throw new InvalidArgumentException("Invalid URL: $url"); +} ``` Suggestion importance[1-10]: 8 Why: This suggestion addresses a good practice of validating the URL before making an API call, which can prevent unnecessary errors and improve robustness.	8
Possible issue	Validate the label before applying URL encoding to prevent potential issues with empty labels ___ **Ensure that the urlencode function is applied correctly to handle special characters in the label names, but also consider validating the label before encoding to avoid unnecessary errors.** [Src/issues.php [86]](https://github.com/guibranco/gstraccini-bot/pull/498/files#diff-6ce0dad4f38891d2e6067af9734b44466fa59d01ddc1ebde9197a21430ec7c4eR86-R86) ```diff -$label = urlencode($label); +if (!empty($label)) { + $label = urlencode($label); +} ``` Suggestion importance[1-10]: 7 Why: The suggestion correctly identifies a potential issue with empty labels, but the proposed validation could be more comprehensive to handle various edge cases.	7
Readability	Use a more descriptive variable name in the loop for better code clarity ___ **Consider using a more descriptive variable name instead of $label inside the loop to improve code readability and maintainability.** [Src/issues.php [85]](https://github.com/guibranco/gstraccini-bot/pull/498/files#diff-6ce0dad4f38891d2e6067af9734b44466fa59d01ddc1ebde9197a21430ec7c4eR85-R85) ```diff -foreach ($intersect as $label) { +foreach ($intersect as $currentLabel) { ``` Suggestion importance[1-10]: 6 Why: While using a more descriptive variable name can enhance readability, `$label` is already a commonly understood term in this context, making this suggestion less critical.	6