Enhance issue label handling in GitHub.php

[guibranco]

Description

• Enhanced the getIssues method to include a new label for "awaiting triage".
• Updated the logic to merge triage results to accommodate the new label.
• Improved overall issue categorization for better clarity and functionality.

---

Changes walkthrough 📝

	Relevant files
Enhancement	GitHub.php Enhance issue label handling in GitHub.php                              src/Library/GitHub.php Added a new label for "awaiting triage" in the getIssues method. Updated the merging of triage results to include the new label. Improved the handling of issue labels for better categorization. +4/-3

Summary by CodeRabbit

• New Features
  • Enhanced issue categorization by adding a new label for "awaiting triage."
  • Improved data aggregation for triage-related issues to ensure comprehensive tracking.

These changes aim to improve the accuracy and usability of the issue tracking system.

[coderabbitai[bot]]

Walkthrough

The pull request introduces modifications to the getIssues method in the GitHub.php file. It adds a new label variation for "awaiting triage" and updates how issues are categorized based on their labels. The changes include the introduction of new result variables for handling triage-related issues and adjustments to the final data structure that compiles these results, ensuring comprehensive categorization of issues.

Changes

File	Change Summary
Src/Library/GitHub.php	Modified the getIssues method to include a new label variation for "awaiting triage" and updated result variables for triage-related issues. Adjusted data aggregation to encompass all variations of triage labels.

Poem

In the garden of code, where issues bloom,
A label of triage dispels all gloom.
With new tags to catch, we gather with glee,
Awaiting our turn, like leaves on a tree.
Hop, hop, hooray! For changes so bright,
Our tracking is better, our future is light! 🐇✨

---

Recent review details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

Commits

Files that changed from the base of the PR and between 15b7e5eb9d2a5d3f6e87ccdc2b3189534e80a030 and 41d2d5836ebf74154f5d3690572729140daf5648.

Files selected for processing (1)

* Src/Library/GitHub.php (3 hunks)

Files skipped from review as they are similar to previous changes (1)

* Src/Library/GitHub.php

--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[penify-dev[bot]]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the changes are relatively straightforward, involving label additions and minor logic updates.
🧪 Relevant tests	No
⚡ Possible issues	Possible Bug: The addition of the new label "awaiting triage" may lead to confusion if not properly documented or if existing functionality does not account for it.
🔒 Security concerns	No

[penify-dev[bot]]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible bug	Remove the reference to the undefined variable $resultTriage3 in the merge operation for $data["triage"] ___ **Ensure that $resultTriage3 is defined before it is used in the array merge for $data["triage"] to avoid undefined variable errors.** [Src/Library/GitHub.php [175]](https://github.com/guibranco/projects-monitor/pull/513/files#diff-88228a2fc233898d2aa4241f4469dc3d7d7c57e3372fb72f5c440f48ad4c8405R175-R175) ```diff -$data["triage"] = array_merge($this->mapItems($resultTriage->items), $this->mapItems($resultTriage2->items), $this->mapItems($resultTriage3->items), $this->mapItems($resultTriage4->items)); +$data["triage"] = array_merge($this->mapItems($resultTriage->items), $this->mapItems($resultTriage2->items), $this->mapItems($resultTriage4->items)); ``` Suggestion importance[1-10]: 9 Why: The suggestion addresses a potential bug by pointing out the use of an undefined variable, which could lead to runtime errors.	9
Maintainability	Eliminate the duplicate assignment of $resultTriage2 to streamline the code ___ **Remove the duplicate assignment of $resultTriage2 to prevent redundancy and potential confusion in the code.** [Src/Library/GitHub.php [164]](https://github.com/guibranco/projects-monitor/pull/513/files#diff-88228a2fc233898d2aa4241f4469dc3d7d7c57e3372fb72f5c440f48ad4c8405R164-R164) ```diff -$resultTriage2 = $this->getWithLabel($allUsers, "issue", "\"🚦awaiting triage\""); $resultTriage2 = $this->getWithLabel($allUsers, "issue", "\"🚦 awaiting triage\""); ``` Suggestion importance[1-10]: 8 Why: The suggestion correctly identifies a redundancy that can lead to confusion, improving code clarity and maintainability.	8
	Consolidate similar calls to getWithLabel to enhance code clarity and maintainability ___ **Consider consolidating the calls to getWithLabel for similar labels to reduce redundancy and improve code readability.** [Src/Library/GitHub.php [156-157]](https://github.com/guibranco/projects-monitor/pull/513/files#diff-88228a2fc233898d2aa4241f4469dc3d7d7c57e3372fb72f5c440f48ad4c8405R156-R157) ```diff $resultWip = $this->getWithLabel($users, "issue", "WIP", ["blocked", "\"🚷blocked\""]); -$resultWip2 = $this->getWithLabel($users, "issue", "\"🛠 WIP\"", ["blocked", "\"🚷blocked\""]); +$resultWip2 = $this->getWithLabel($users, "issue", "WIP", ["blocked", "\"🚷blocked\""]); ``` Suggestion importance[1-10]: 6 Why: While consolidating similar calls can improve readability, the suggestion does not address a critical issue and is more of a stylistic improvement.	6
Possible issue	Change the null label to an empty string to avoid potential issues with the getWithLabel method ___ **Ensure that the getWithLabel method can handle null values for the label parameter appropriately, as passing null may lead to unexpected behavior or errors.** [Src/Library/GitHub.php [155]](https://github.com/guibranco/projects-monitor/pull/513/files#diff-88228a2fc233898d2aa4241f4469dc3d7d7c57e3372fb72f5c440f48ad4c8405R155-R155) ```diff -$resultOthers = $this->getWithLabel($users, "issue", null, ["WIP", "\"🛠 WIP\"", "bug", "\"🐛 bug\"", "triage", "\"🚦awaiting triage\"", "blocked", "\"🚷blocked\""]); +$resultOthers = $this->getWithLabel($users, "issue", "", ["WIP", "\"🛠 WIP\"", "bug", "\"🐛 bug\"", "triage", "\"🚦awaiting triage\"", "blocked", "\"🚷blocked\""]); ``` Suggestion importance[1-10]: 7 Why: Changing the null label to an empty string is a good practice to avoid potential issues, but the suggestion does not address a critical bug.	7

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions[bot]]

Infisical secrets check: :white_check_mark: No secrets leaked!

Scan results:

9:48AM INF scanning for exposed secrets...
9:48AM INF 466 commits scanned.
9:48AM INF scan completed in 208ms
9:48AM INF no leaks found

[github-actions[bot]]

:rocket: Postman tests are disabled

:x: The Postman collection run is disabled.

[github-actions[bot]]

:test_tube: Request tests summary

:white_check_mark: All test requests succeeded

[github-actions[bot]]

:mag: Database integrity summary

:white_check_mark: The database integrity check succeeded

[github-actions[bot]]

:fire_engine: Smoke tests summary

:fire: Smoke tests passed!