guicho271828 / trivia

Pattern Matcher Compatible with Optima
Other
332 stars 22 forks source link

Some cleanups for ASDF 3.3 #78

Closed fare closed 7 years ago

guicho271828 commented 7 years ago

I saw lots of similar pullreqs of yours on other projects. Is there any reason you make keywords into strings? Isn't a formal (and brief) announcement on website+reddit more appropriate for such changes?

fare commented 7 years ago

I indeed started a document on this topic, but I haven't finalized it yet: https://gitlab.common-lisp.net/asdf/asdf/blob/plan/doc/best_practices.md

guicho271828 commented 7 years ago

just asking, but are you working as a group, i.e., does several lispers involved in developing the best practices? Im not saying it should already be a consensus, but a reviewer or two might help regulate it

fare commented 7 years ago

I admit I did it alone, especially since Robert had health issues and was not currently not available for much help. I do welcome merge requests on https://gitlab.common-lisp.net/asdf/asdf/merge_requests though.