holub008 commented 5 years ago

Hey Guido - I'm porting parts of this package to a Node module and ran into a couple trivial code issues while reading through:

Unused matrix A in multiarm()
Incorrect preallocation size for v. It should be the number of pairwise contrasts, not the number of treatments
- Note this does not represent a serious bug (besides a trivial performance impact) since R auto-grows vectors for out of range assignments.

Thanks for this awesome package!

codecov-io commented 5 years ago

Codecov Report

Merging #5 into develop will increase coverage by <.01%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           develop      #5      +/-   ##
==========================================
+ Coverage     0.06%   0.06%   +<.01%     
==========================================
  Files           65      65              
  Lines         9273    9272       -1     
==========================================
  Hits             6       6              
+ Misses        9267    9266       -1

Impacted Files	Coverage Δ
R/multiarm.R	`0% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d19da93...0ca766a. Read the comment docs.

guido-s commented 5 years ago

Pull request incorporated in commit 3c6fd8fa6a6e747de5dfb99233021a272cb95715 .

guido-s / netmeta

Code nits #5

Codecov Report