search

guidocioni / no-more-wet-rides-new

2 stars 0 forks source link

Handle cases when reverse geocoding fails #22

Open guidocioni opened 3 months ago

guidocioni commented 3 months ago

In this case the place does not have lon or lat information, which causes an error to occur

guidocioni commented 3 months ago

In 2aa18cfae4e1f5cf944c2d27d4caf21fee72b1d0 I removed the type=address query parameter to the reverse geocoding query, which was obviously limiting results only to an address type. The problem, however, it's not completely solved.

For both geolocation and mapClick cases, if the lat, lon coordinates obtained are far away from a city, it could be that the reverse geocoding does not return any result. This breaks everything, as we are supposed to put a string into the input text for the search. In this case, I think we should just return a "custom location" string but leave the lat/lon coordinates found.

Also, when geocoding/mapclicking we perform a redundant action as we're searching again the location when pressing on generate. Can we get read of this??