search

guidoferreyra / Geist

SIL Open Font License 1.1
0 stars 0 forks source link

Vertical Metrics revision #1

Closed vv-monsalve closed 1 week ago

vv-monsalve commented 4 weeks ago

Hi @guidoferreyra,

After pulling the latest files at commit 4a7d292 and giving them an initial revision in preparation for the GF onboarding, the line height looks a bit tight. I recommend revising it.

Even though they meet the minimal requirement of 120%, we strongly recommend setting it to 130% as the safest value. This will allow the font to be updated in the future with added language support, such as Vietnamese. This has already proven to work in some projects. You can find more details about this here.

Screenshot 2024-08-21 at 20 18 28
guidoferreyra commented 1 week ago

@vv-monsalve can you check it now? I made it 130%

vv-monsalve commented 1 week ago

Fonts VM at commit 972ecc2 look good.