search

guidokessels / xwing-data

An easy-to-use collection of data and images from X-Wing: The Miniatures Game by Fantasy Flight Games.
93 stars 37 forks source link

Ship Firing Arcs #132

Closed guidokessels closed 7 years ago

guidokessels commented 7 years ago

As discussed in https://github.com/guidokessels/xwing-data/issues/122.

@FreakyDug @Mu0n Please review.

Technically the Primary Weapon Turret is not a firing arc. But I think it's better to have it in here anyway than adding an additional pwt: true flag. What do you think?

Mu0n commented 7 years ago

True about primary weapon being able to fire out of arc.

Also, a follow-up topic that I thought about this week: do we want to include huge ships in all of this? Regarding my needs for vassal, I really don't care either way because they are almost each their own unique case, and I'll just accept that to bring a new one in will require classic vassal editor stuff rather than build one from scratch during the autospawn .

philipdouglas commented 7 years ago

Looks good to me.

Turret's aren't an arc but they're represented on the card and on the base like one, so I think it makes more sense to include them than to treat them as a special case.

guidokessels commented 7 years ago

@Mu0n - I've only added it for non-huge ships as all the huge ship firing arcs need custom work anyways. I think it's fine to keep it to small and large ships only.