guidokessels / xwing-data

An easy-to-use collection of data and images from X-Wing: The Miniatures Game by Fantasy Flight Games.
93 stars 37 forks source link

TIE Aggressor data shouldn't have turret #175

Closed jmthompson2015 closed 6 years ago

jmthompson2015 commented 6 years ago

In ships.js, the TIE Aggressor entry has:

"firing_arcs": [ "Front", "Turret" ],

Should be (I think):

"firing_arcs": [ "Front" ],

shiftregister-vg commented 6 years ago

Why shouldn't it? It can equip turrets.

guidokessels commented 6 years ago

@jmthompson2015 You are correct. The Turret firing arc should only be there if the TIE Aggressor had a PWT, which it doesn't.

@stevegood The Turret slot is in the slots field and is different from the Turret firing_arc.

Feel free to open a PR, or I can fix it when I get home this evening.

shiftregister-vg commented 6 years ago

I was clearly confused on what the criteria was for being included in the firing_arcs array... 😝