search

guidokessels / xwing-data

An easy-to-use collection of data and images from X-Wing: The Miniatures Game by Fantasy Flight Games.
93 stars 37 forks source link

Use typographically correct quotes #183

Closed jacobcarpenter closed 1 year ago

jacobcarpenter commented 6 years ago

A number of the data fields contain actual text from the cards. The cards use typographically correct quotation marks.

The data should use the correct quotes as well.

jacobcarpenter commented 6 years ago

Versioning may be a minor concern. I'm not entirely sure how everyone is using this data.

It's possible, for instance, that some consumers may have stored pilot names, and a change to the data may require some small amount of migration on their part.

I'm unsure of how you want to reflect this potential in the semantic versioning.

jacobcarpenter commented 6 years ago

@guidokessels any objection to this change? In addition to matching the card text, the typographic quotes also improve the aesthetics. Compare:

Test Pilot "Blackout"

vs.

Test Pilot “Blackout”