guidone / node-red-contrib-chatbot

Visually build a full featured chat bot for Telegram, Facebook Messenger, Whatsapp and Slack with Node-RED. Almost no coding skills required.
http://red-bot.io
930 stars 188 forks source link

Telegram: Conversation node seems to add wrong "modify_message_id" #153

Closed stefanoco closed 6 years ago

stefanoco commented 6 years ago

This used to work until days ago, started behaving like this after (apparently unrelated) flow moditications.

I have a rather complex flow, where NodeRED events should result in messages sent to a specific chatId. So I'm chaining:

The result: an error in the NodeRED console "Error: ETELEGRAM: 400 Bad Request: message to edit not found" and indeed the message coming out of the "Conversation" node contains a wrongly generated modify_message_id field, see screenshot

screenshot at 2018-01-04 12 45 39

guidone commented 6 years ago

Which version of redbot are you using? Seems like a bug I've fixed a while ago

stefanoco commented 6 years ago

...yes discovered now reading #136 indeed. I upgaded to 0.9.9 right now and can't connect to my bot anymore unfortunately! Now when deploying a flow I get: "Error creating chatbot : no context provider specified." but I don't want to specify a context provider...

guidone commented 6 years ago

Ok, you have to specify a context provider in the bot config, the "memory" one is ok for testing. In few minutes I'll push a fix for this (if no context provider is specified it uses the default "memory")

stefanoco commented 6 years ago

Thanks waiting for the fix

-- Stefano Costa R&D, Managing Director Bluewind Embedded Systems M. +39 335 6565749 https://t.me/stefanoco http://www.bluewind.it so long, and thanks for all the fish

Il 4 gen 2018, 13:11 +0100, Guidone notifications@github.com, ha scritto:

Ok, you have to specify a context provider in the bot config, the "memory" one is ok for testing. In few minutes I'll push a fix for this (if no context provider is specified it uses the default "memory") — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

guidone commented 6 years ago

Ok, pushed 0.9.10

stefanoco commented 6 years ago

Yes works now! Before I close the issue: can't specify any context provider type in the dialog (defaulting to memory now) is this normal?

guidone commented 6 years ago

It should work

https://d.pr/v/p1EJuv

what happens exactly?

stefanoco commented 6 years ago

Nothing actually: same as your workflow, the drop down menu is empty...

screenshot at 2018-01-04 14 40 26

maybe due to NodeRED version? 0.17.5 here and can't upgrade for a few days

guidone commented 6 years ago

Even if you open the drop down, you see nothing? 0.17.5 is fine, I'm using it too

stefanoco commented 6 years ago

Yes can't see nothing. Wait: I'm using Telegram only, the documentation tells that memory only is available for Telegram is this correct?

guidone commented 6 years ago

Sorry documentation is not updated yet, the new chat context system is available for slack and telegram (and facebook soon)

Do you see this call in the the JS console of the borwser

https://d.pr/i/GzlUB3

or any particular error? Which version of node?

stefanoco commented 6 years ago

If I'm looking the correct tab the answer to the call is:

<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<title>Error</title>
</head>
<body>
<pre>Cannot GET /redbot/context-providers</pre>
</body>
</html>
stefanoco commented 6 years ago

...and node 4.5.0

guidone commented 6 years ago

Ok, perhaps it's due to the host name (I'm testing locally), let me check

guidone commented 6 years ago

I guess it's because you have mounted node-red control panel in /admin and not the root, the correct link with your config should be https://myhome.bluewind.it/admin/redbot/context-providers

I'll fix it

stefanoco commented 6 years ago

yes this is my setup (seen also on some Raspberry SD images)

guidone commented 6 years ago

Ok, found it, I'll push the fix later today

guidone commented 6 years ago

Ok, fixed in 0.9.11

Thanks for the feedback

stefanoco commented 6 years ago

Works perfectly now, thanks for your effort!