search

guidorice / mojo-pytest

Mojo🔥 language test runner plugin for pytest. (aka pytest-mojo)
MIT License
46 stars 1 forks source link

Review of failed tests logic and Integration Tests #5

Closed lleites closed 10 months ago

lleites commented 10 months ago

FIxes #1

Now tests fail either by an unhandled Error or by a failed assertion from the Mojo standard lib testing module. By just using the standard lib assertions, it is possible to collect all the items, even if one of them fails in between.

I Also added Integration Tests as a GitHub Workflow, for that to work you need to setup the MODULAR_AUTH GitHub secret with the value of the Modular key you can find at https://developer.modular.com/download, check the curl command.

The documentation is not updated yet, I am waiting for us to discuss the implementation to do it.

lleites commented 10 months ago

Thank you for your comments, let me address them one by one. 1 - I am unable to reproduce the error in your repository, it works well for me.

Steps I did and still got all green tests:

pip uninstall pytest-mojo 
pip install git+https://github.com/lleites/mojo-pytest.git

Can you please try to uninstall and install the plugin again? Do you have mojo available in your path? First, please be sure to have a green setup with the current mojo-pytest version

Full log attached, see how I move from version 0.1.0 to 0.1.1 of the plugin reinstallation.log

lleites commented 10 months ago

README.md updated with new conventions

guidorice commented 10 months ago

@lleites, yes it is working for me. I tried all the modes of passing and failing tests. Not sure what I did wrong before, probably messed up my conda environment. :)