search

guigarage / ObserverPattern

Basic Java observer API
Apache License 2.0
7 stars 7 forks source link

Test the Observable for String #14

Closed ameissne closed 7 years ago

ameissne commented 7 years ago

Issue: https://github.com/guigarage/ObserverPattern/issues/13

hendrikebbers commented 7 years ago

Cool :) But can you please add the method in a UnitTests? See https://github.com/guigarage/ObserverPattern/blob/master/impl/src/test/java/com/guigarage/observer/BasicObservableTest.java

hendrikebbers commented 7 years ago

@ameissne please change the name of this PR to something that makes sense ;)

hendrikebbers commented 7 years ago

Code looks good but now we have a conflict 😱

You can merge the master of this repo in your forked branch to solve the conflict or do it directly here in github