search

guilatrova / tryceratops

A linter to prevent exception handling antipatterns in Python (limited only for those who like dinosaurs).
MIT License
427 stars 25 forks source link

Add `BaseException` to raise-vanilla-class rule (`TRY002`) #74

Closed epenet closed 1 month ago

epenet commented 1 month ago

Fixes #73

guilatrova commented 1 month ago

This makes sense to me, but we need tests to ensure this is covered.

If you can't, I'll do it later over the week.

guilatrova commented 1 month ago

Your commits are also not compliant with our guidelines (to ensure deployments will be triggered properly). I'll recreate this PR later with your suggestion. I believe it's a good idea.

epenet commented 1 month ago

This makes sense to me, but we need tests to ensure this is covered.

If you can't, I'll do it later over the week.

Thanks for taking charge of this - I'm not sure when I would get a chance to adjust the PR.

FYI: the corresponding PR in ruff has been accepted and merged. https://github.com/astral-sh/ruff/pull/12620

guilatrova commented 1 month ago

Done in d2a6beb