guilbaults / infiniband-exporter

Prometheus exporter for a Infiniband Fabric
Apache License 2.0
47 stars 21 forks source link

Do not export zero counter values. #29

Closed gabrieleiannetti closed 3 years ago

gabrieleiannetti commented 3 years ago

Hi,

I would suggest to drop 0 values on counter metrics.
By now I do not see any reason to keep them...
In our case we could save up to ~55% of the counter metric values.
As far as I know the rate function for plotting the rate requires at least two values not zero. So keeping the first value with 0 would not be required. This aspect could have been important to keep 0 values.

Best Gabriele