search

guilds-plugin / Guilds

Adding RPG to your server has never been more fun and action-packed!
MIT License
170 stars 58 forks source link

Some commands show staff names even if they are in vanish #650

Closed hotspuraz closed 1 year ago

hotspuraz commented 1 year ago

Description

Some commands list all online players' names when you use them, even operators in vanish and staff using other vanish plugins. image

Expected Behavior

Vanished players should be treated the same as offline players, and commands like /guild invite or /guild war challenge should say the player is offline.

Actual Behavior

Several commands will send messages to the player that either directly tell them via a list of names or send them a message which suggests that the player is online.

Possible Fix

image

Steps to Reproduce

Using a plugin like VelocityVanish, put a player into vanish and then on another account use /clan invite <name> and it will invite them. If you use the name of someone who is offline then it will give you a list of players online, including those in vanish.

Context

This is highly abusable by players, especially ones looking to cheat on the server.

Your Environment

darbyjack commented 1 year ago

I believe this was fixed via https://github.com/guilds-plugin/Guilds/commit/8c8348e9328576e5da72b2b022289dc5dfb9f9ec