guildxyz / guild.xyz

A tool for token-curated communities.
https://guild.xyz
3.27k stars 409 forks source link

Add support for Tally Ho wallet #474

Closed beemeeupnow closed 7 months ago

beemeeupnow commented 2 years ago

Tally Ho, the community-owned open source wallet: https://tally.cash/

In the current state, injected browser wallets that are not explicitly listed are not able to connect.

No "Injected" or "Browser wallet" option is presented, and you can't work around it by clicking the "Metamask" option because it directs you to install Metamask.

This blocks Tally Ho users from connecting at all.

web3-react integration is in-progress at Uniswap/web3-react#498

another option is to add it based on InjectedConnector: https://docs.tally.cash/tally/developers/integrating-dapps#web3-react-projects

beemeeupnow commented 2 years ago

I'm happy to see that the MetaMask option no longer switches to "Install MetaMask" when there is a different injected wallet extension in use.

Currently the "Sign message to verify that you're the owner of this account." part is not working with Tally Ho.

Edit: I had to Ctrl-F5 (force refresh) the page and the personal_sign call then came through.