search

guileen / node-sendmail

send mail without setting up a SMTP server
http://guileen.github.com/node-sendmail
MIT License
559 stars 110 forks source link

1.2.0 breaks apps using node 4.X #42

Closed glenwinters closed 6 years ago

glenwinters commented 7 years ago

My project broke because I was using ^1.1.1 for sendmail in my package.json and auto-upgraded to 1.2.0. I'm using 4.X and 1.2.0 introduced ES2015 syntax that doesn't work on 4.X. It seems like introducing ES2015 should be part of a major version, not a minor version. Is there an assumption that you have to be using node 6.X to use this library? Perhaps that should be stated somewhere.

GreenPioneer commented 6 years ago

I agree with you that it should be stated somewhere.

I don't think there is an assumption of "you have to be using node 6.X to use this library." Because the old version works just fine still.

Updated sendmail.js to ES2015 - Commit

Regardless, @glenwinters I think you made a good point we should/could do going forward when we update

Sorry for the late response

glenwinters commented 6 years ago

Thanks for the reply! It would be helpful to add "Converted to ES2015" under version 1.2. You can go ahead and close this issue.

GreenPioneer commented 6 years ago

updated @glenwinters - https://github.com/guileen/node-sendmail/blob/master/Readme.md