guileen / node-sendmail

send mail without setting up a SMTP server
http://guileen.github.com/node-sendmail
MIT License
559 stars 110 forks source link

STARTTLS support and some other code cleanup #68

Closed NGTmeaty closed 4 years ago

NGTmeaty commented 4 years ago

Description

The changes are here to send mail in an encrypted fashion with STARTTLS if possible. This increases mail deliverability. There are also some other code cleanup things in here.

Motivation and Context

This massively helps mail deliverability and assists in keeping emails slightly more private. STARTTLS has been adopted by every major email provider and is quite useful (and pretty easy to implement.)

How Has This Been Tested?

We've setup a node-sendmail server and have been using it to send hundreds of emails with the changes we made here perfectly fine. The code has worked perfectly, and we've yet to see any errors (that haven't been fixed) linked to it.

Types of changes

Checklist:

@GreenPioneer thanks!

GreenPioneer commented 4 years ago

@NGTmeaty @JorgenVatle - really appreciate the time you guys took to give back to the project!!!