guilemouse / Overthrow

An effort to balance and fix the dynamic and persistent revolution platform for Arma 3.
https://steamcommunity.com/sharedfiles/filedetails/?id=2572102841
GNU General Public License v2.0
0 stars 3 forks source link

Item name/image check for Shops and faction leader shops too. #31

Open guilemouse opened 3 years ago

guilemouse commented 3 years ago

Issue: This is just a hunch but, I remember seeing faction leaders and/or shops selling items that didn't have an image or something similar. Might be good to double down on checking it for no _name and no _pic variables when spawning a list of items for players to buy.

Solution: See update on #28, (https://github.com/guilemouse/Overthrow/commit/faed39ec6a1b8dabbb246082027bbcd785ea344e) there was fix applied for import/warehouses from that commit. All it needs is to replicate it via shop owners and faction leaders too.

Add this

if (!(_pic isEqualTo "") && !(_name isEqualTo "")) then { ....};