search

guilgautier / DPPy

Python toolbox for sampling Determinantal Point Processes
https://dppy.readthedocs.io
MIT License
219 stars 52 forks source link

Work on Descent processes involved in exotic_dpps.py, parent class, plot decorator and documentation #26

Closed guilgautier closed 5 years ago

Naereen commented 5 years ago

Note that there's a weird build error on Travis when installing cvxopt might be a version issue or gcc.. @Naereen any insight ? see https://travis-ci.com/guilgautier/DPPy/jobs/153285804

@guilgautier indeed apparently Travis in unable to locate the LAPACK and BLAS libraries (linear algebra) required to build cvxopt from scratch. (/usr/bin/ld: cannot find -llapack and /usr/bin/ld: cannot find -lblas)

(note: it's maybe a bad sign that Travis has to build cvxopt for every build?)

For my system with Python 3.6.6, when I do:

$ sudo pip3 install --upgrade --force-reinstall cvxopt
Collecting cvxopt
  Using cached https://files.pythonhosted.org/packages/9c/b4/44a825b16ae366f163cd55c0ad6c51391de52cb5b8da3dcbeee242bd4c01/cvxopt-1.2.2-cp36-cp36m-manylinux1_x86_64.whl
Installing collected packages: cvxopt
  Found existing installation: cvxopt 1.2.2
    Uninstalling cvxopt-1.2.2:
      Successfully uninstalled cvxopt-1.2.2
Successfully installed cvxopt-1.2.2

so no build step is required?

Maybe sudo apt install libblas-dev liblapack-dev or something like this is required. Maybe it's just a question of adding manually the path of the two missing / not found libraries.

Naereen commented 5 years ago

Also @guilgautier I don't know why your Travis build are using Python 3.4, you should consider upgrading to 3.6 (or better, 3.7, it's out now!)

guilgautier commented 5 years ago

Actually, there's been a new release 1.2.2 of cvxopt from Oct 18... That seems to be the reason. I've enforced the previous version 1.2.1 and green light is back again https://travis-ci.com/guilgautier/DPPy/builds/89036771

guilgautier commented 5 years ago

Merged the fix in the master branch #27

Naereen commented 5 years ago

OK good to know! I'll remember to check out if any new version of a library was released recently, in case I ever find myself such a bug again.