guilgautier / DPPy

Python toolbox for sampling Determinantal Point Processes
https://dppy.readthedocs.io
MIT License
219 stars 52 forks source link

Use inheritance with BetaEnsemble as a parent class whose children are Hermite, Laguerre... #34

Closed guilgautier closed 5 years ago

guilgautier commented 5 years ago

Is your feature request related to a problem? Please describe. As of now, class BetaEnsemble class is used as a big object to instanciate Hermite, Laguerre ... This is not very natural to use nor easy to maintain, there are too many

if ...:
elif ...:

The call to sample() method is not very handy to use, see also #29

Describe the solution you'd like

Describe alternatives you've considered NTR

Additional context The result could look like

hermite = HermiteEnsemble(beta=2)
hermite.sample_full_model()
hermite.sample_banded_model()
guilgautier commented 5 years ago

Need to update:

guilgautier commented 5 years ago
guilgautier commented 5 years ago

Need to update