search

guilgautier / DPPy

Python toolbox for sampling Determinantal Point Processes
https://dppy.readthedocs.io
MIT License
219 stars 52 forks source link

Lots of duplicated code in tests #45

Closed guillep closed 4 years ago

guillep commented 4 years ago

It looks (at a glance) that the tests share lots of common code. Would be nice to refactor that into common functions. This would help also in the increase of the readability.

guillep commented 4 years ago

This happens in test_correlation_functions, test_cardinality_of_finite_dpp_samples

guillep commented 4 years ago

Also in https://github.com/guilgautier/DPPy/blob/master/tests/test_descent_processes.py

guillep commented 4 years ago

And https://github.com/guilgautier/DPPy/blob/master/tests/test_instanciation_of_finite_dpps.py

guillep commented 4 years ago

And https://github.com/guilgautier/DPPy/blob/master/tests/test_ust_samplers.py