Closed guillep closed 4 years ago
It looks (at a glance) that the tests share lots of common code. Would be nice to refactor that into common functions. This would help also in the increase of the readability.
This happens in test_correlation_functions, test_cardinality_of_finite_dpp_samples
test_correlation_functions
test_cardinality_of_finite_dpp_samples
Also in https://github.com/guilgautier/DPPy/blob/master/tests/test_descent_processes.py
And https://github.com/guilgautier/DPPy/blob/master/tests/test_instanciation_of_finite_dpps.py
And https://github.com/guilgautier/DPPy/blob/master/tests/test_ust_samplers.py
It looks (at a glance) that the tests share lots of common code. Would be nice to refactor that into common functions. This would help also in the increase of the readability.