guilgautier / DPPy

Python toolbox for sampling Determinantal Point Processes
https://dppy.readthedocs.io
MIT License
219 stars 52 forks source link

Testing new features in branch dppvfx-dev #52

Closed guilgautier closed 4 years ago

guilgautier commented 4 years ago

It is important to test the core features of the vfx dpp sampler which is being integrated in the dppvfx-dev branch

Generally speaking, some efforts must be made regarding the description of the different functionalities through more detailed comments and more explicit variables

A "global" test is performed through the sampler itself (see here) but the internal features should be tested as well


In finite_dpps.py

To clean up the big FiniteDPP class I would put the following in exact_sampling.py


In bless.py

Write the mathematical meaning of "(eps, lambda)-accurate dictionary" somewhere and refer to specific Theorem/equation in the reference

In utils.py

guilgautier commented 4 years ago

Merged in #54