search

guilhemmarchand / TA-jira-service-desk-simple-addon

Atlasian JIRA add-on for Splunk alert actions
11 stars 8 forks source link

Issue in dedup behaviour when dedup is enabled but the issue was resolved, closed or cancelled #102

Closed nadiagutierrez89 closed 3 years ago

nadiagutierrez89 commented 3 years ago

Hello Guillem,

Your app is great! I was running a few tests about generating a ticket with dedup behaviour enabled, and detected an issue when you have two tickets with the same md5 hash and the first has a Status Category thats in "JIRA dedup excluded status categories". In this case the key saved in KVstore for the second ticket is a random hash instead the MD5 Hash. Looking for the problem in the code, i check "modalert_jira_service_desk_helper.py" and i found a missing tab in line 526. I attached a print of the original line and the fixed line. I proved the functionality post fix and it work ok.

Apologies for my poor english. Best regards! AddonJiraFixedl AddonJiraOriginal

guilhemmarchand commented 3 years ago

Hi @nadiagutierrez89 !

Thank you very much for reporting this, much appreciated ;-) Ha ha no worries at all for your English, I am not a native speaker either!

All right, I see the issue indeed, exactly in this block:

            else:
                helper.log_info(
                    'jira_dedup: An issue with same md5 hash (' + str(jira_md5sum) + ') was found in the backlog '
                    'collection, as jira_dedup is not enabled a new issue '
                    'will be created, entry:={}'.format(response.text))
            jira_dedup_md5_found = True

This will be fixed for the Version 2.0.0 of the Add-on, which I am currently running with the latest validation steps.

Note that support for Splunk 7.2.x / Splunk 7.3.x is dropped and only Splunk 8.x will be supported. Potentially I could drop a corrective release for this bug especially.

nadiagutierrez89 commented 3 years ago

Thank you so much!!

King regards :D