search

guilhemmarchand / TA-jira-service-desk-simple-addon

Atlasian JIRA add-on for Splunk alert actions
11 stars 8 forks source link

Version 1.0.29 #86

Closed guilhemmarchand closed 3 years ago

guilhemmarchand commented 3 years ago
guilhemmarchand commented 3 years ago

Hi @remg427 !

This is the final PR regarding your great contribution ;-)

I had to fixes and improve a few things which you might be interested to know, especially I handled a differentl logic in the Python wrapper to provide a proper answer to Splunk depending on the conditions, when performing a method not rendering a JSON object (such as DELETE), the custom command was rendering an error to Splunk while the action was performed properly on JIRA.

With these changes, we render a nice formated answer with an interesting action field allowing to quickly understand if the rest call was successful.

Other updates were essentially adding the args to the searchdbnf.conf to get the syntax highlighting on these, and a few minor other things.

Again your contribution was more than welcomed, thanks for this.

Guulhem

remg427 commented 3 years ago

Hi @guilhemmarchand thank you for implementing this enhancement. Iniitial PR was indeed more a prototype and again you raise that to professional level. Sure I will reuse your implementation on my app like many of other features you have set. Keep on with very impressive work here