search

guilhermeaiolfi / flx

A JavaScript router that loves any framework view layer
1 stars 0 forks source link

Merge params and queryParams #1

Open guilhermeaiolfi opened 9 years ago

guilhermeaiolfi commented 9 years ago

In the enter hood merge params like:

var params = jQuery.extend(ctx.transition.routes.queryParams, current_route.params);

jQuery is already available. But maybe lodash should be considered.

silentworks commented 8 years ago

I saw this and was wondering why not use lodash _.deepClone method instead? I might not have/want jQuery in my project at all.

guilhermeaiolfi commented 8 years ago

Yes. Using _.deepClone there and remove the jQuery.on/off`` for thehashchange``` event we could remove the jQuery dep.