[bug] Full card combo select bug

guilhermebkel / uno-game

:flower_playing_cards: An UNO Game made in Javascript

https://uno.guilherr.me

MIT License

207 stars 59 forks source link

[bug] Full card combo select bug #2

Closed guilhermebkel closed 3 years ago

guilhermebkel commented 3 years ago

In this game, the player is able to make card combo by clicking on them and grouping the ones with same type, but, the first card selected must respect the card on the top stack card (since the next play must respect the last one).

Being minded about that, we have the following problem:

When selecting a full card combo and de-selecting de first combo card, the combo works even if the first card of the combo does not start with a valid type that matches the top stack card.

ArcaneDiver commented 3 years ago

Hey, could you assign me also this issue too because i have already resolved this issue😅. Then tomorrow i will make a PR.

guilhermebkel commented 3 years ago

@ArcaneDiver Hello! Thanks for solving this issue 😉, I'll assign you that.