search

guilhermebkel / uno-game

:flower_playing_cards: An UNO Game made in Javascript
https://uno.guilherr.me
MIT License
207 stars 59 forks source link

Middle pack freezes in late game #25

Closed outrowender closed 2 years ago

outrowender commented 3 years ago

Sometimes in late game with 6 players, the middle pack freezes and not show the actual card for all players in room. The game continues, but we only knew wich card is because of the cards wich can be played, start to glow.

guilhermebkel commented 3 years ago

Hey @outrowender, thanks for reporting that bug :)

What do you mean is like, sometimes in the game with a full room (with multiple cards drawn), the top card on the center of the game shows per example a "3-red" card by mistake but the correct card is a "4-yellow"?

When this happens again, can you try to refresh the page in order to know if the correct card is shown? (it is because I think this bug is something related to having a lot of cards rendered on client, so probably the fix needs to be done there)

outrowender commented 3 years ago

the top card on the center of the game shows per example a "3-red" card by mistake but the correct card is a "4-yellow

Yes @guilhermebkel! I will try refresh the page if happens again!

GlowingUmbreon commented 2 years ago

This happens when there are too many cards in the middle, a refresh will fix it.

guilhermebkel commented 2 years ago

Got it @GlowingUmbreon! I was thinking about limiting the amount of cards in the middle (rendered by front-end), what do you think?

GlowingUmbreon commented 2 years ago

Definitely, Me and my friends had to refresh the game every couple of minutes over-wise it would become unplayable.

guilhermebkel commented 2 years ago

Sure! Fixed at https://github.com/guilhermebkel/uno-game/commit/10a42a4d223c8f2c50f404277effa2ee7bfe107f

GlowingUmbreon commented 2 years ago

Sure! Fixed at 10a42a4

Has this been published to the website? I was playing with my friends earlier this week and it still appeared to occur.

guilhermebkel commented 2 years ago

@GlowingUmbreon Yep, it was published. Can you try cleaning up browser cache in other to see if this problem happens again? (I'm currently having some trouble with service worker creating cache on front end and deploys not working)