search

guilhermebkel / uno-game

:flower_playing_cards: An UNO Game made in Javascript
https://uno.guilherr.me
MIT License
207 stars 59 forks source link

Resolve react key warning #6

Closed ArcaneDiver closed 3 years ago

ArcaneDiver commented 3 years ago

Hey, i noticed some key warning from react which were generated by the fact that some React fragment were been used without a key. So here Is my PR to resolve that 😁.

guilhermebkel commented 3 years ago

Hello @ArcaneDiver!

At first thanks for being proactive to fix this issue! 😄

I just gave a look on the commit and everything looks good! (the only thing that I noticed that could not be so good would be using indexes as keys but this is only valid if there is some ordination happening, so using indexes as key on this game is really acceptable since there is no ordination on elements 🙂)