search

guilhermebkel / uno-game

:flower_playing_cards: An UNO Game made in Javascript
https://uno.guilherr.me
MIT License
207 stars 59 forks source link

Hotfix/combo deselect #7

Closed ArcaneDiver closed 3 years ago

ArcaneDiver commented 3 years ago

Hey 👋, here is my PR to resolve #2. Resolution: when i deselect a card i check that if the card on the top of the card stack is at the same color of the deselected card and if there is no other card with the same color or type then all cards are deselected.

guilhermebkel commented 3 years ago

Hello @ArcaneDiver! Thanks for making this pull request!

I'll make a code review on this weekend 😁

ArcaneDiver commented 3 years ago

Hey, first I would like to congratulate you on the fantastic code review. About the first two points, i'll make as soon as possible a commit that will refractor the code following you code standards. But i think that you should change some eslint settings in order to highlight practices that does not follow your code standards.

But about the third point i'm going to make another commit that modify a little bit the if statement that check if among the remaining cards there is a card that can still be part of the combo because a card can still be part of a meld if and only if the card is the same type as the top card. About checking only the first card I think you are right so I will change that too.

guilhermebkel commented 3 years ago

Hello @ArcaneDiver!

Thanks for replying! I'll try to add these code standard rules to ESLint 😁

ArcaneDiver commented 3 years ago

If you would i could make another PR with eslint settings according to your code base rules.

guilhermebkel commented 3 years ago

Hello @ArcaneDiver!

I would be really grateful if you do that PR adding the new eslint rules 😊

I've noticed you added the code review changes to the other PRs, I'll give a look at it soon and merge it 😁

Thanks for helping!